-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported filament shrinkage compensation for XY and independent Z from Prusa Slicer (fixing MMU painting, seam painting, support painting issues) #6507
Conversation
…ic to be 100 = no shrinkage to be consistent with orca definitions
Nice, and does this also solve the issue that mmu/seam/support painting not working properly when shrinkage != 100%? |
Have not tested seam & support painting but probably yes, as it simply applies an XYZ scale transform to the whole object instead of just the perimeters, that the old version used to do, from what I understand. EDIT: Tested below, it works. |
If anyone fancies a code review as it’s quite a long-ish merge, hence is very well possible I missed something in the merge, the prusa commit for this feature is here: prusa3d/PrusaSlicer@4b8fe98 |
Awesome! |
…compension---port-from-Prusa-slicer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
Thank you!!!
No worries :) 🎉 |
Ported filament shrinkage compensation from Prusa Slicer. Updated Prusa's calculation logic to be 100 = no shrinkage to be consistent with orca definitions and any saved profiles from the users (vs. Prusa that uses a 0 as no scaling).
Can adjust shrinkage compensation on X, Y as well as Z (separately) and is compatible with multi colour/material prints.
Existing user filament compensation settings will migrate to XY shrinkage (as the parameter name is unchanged). Z will be the default of 100%.
Fixes #5756
Fixes #5152
Fixes #4551
Fixes #5664
Fixes #4091
Supersedes PR: #5774
Screenshots/Recordings/Graphs
Tests
The below tests were performed:
All of the 6 above did not work in the current implementation (as known).