Filter out micro segments generated during the overhang slowdown process #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Will need more testing in general before release - whole I don’t think it will hurt it’s puzzling why these code artefacts exist in the first place as this code again is identical to prusa. Unless we’re one step ahead 😀 |
igiannakas
deleted the
Filter-out-micro-segments-generated-during-the-overhang-slowdown-process
branch
that is what BETA version for ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the overhang slowdown process, the overhang lines are split to apply the slowdown algorithm.
However there are certain cases where micro segments are generated (less than 0.01 mm in length). These micro segments result in wall extrusion consistency issues as reported here: #6583
This PR aims to filter out the generation of these micro paths by ensuring that any new points generated are at least 25% of the line width long.
Fixes #6583
Screenshots/Recordings/Graphs
Before:
Micro paths generated.
After:
Micro paths filtered out.
Tests
Confirmed no regression in overhang performance due to filtered out segmentation with standard test model collection
Before (2.2 beta):
After (this PR):
Unchanged slowdown areas between the two versions.