Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerk limit warning fix #7660

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Conversation

Xelinor
Copy link
Contributor

@Xelinor Xelinor commented Dec 4, 2024

Description

This PR corrects for a warning that will be re-introduced with #7659

It moves the artificial jerk limits from the machine limits to the process limits where they should have been from the beginning. It also raises the jerk for fast mode, since that shouldn't have been limited for quality reasons in the first place.

Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noisyfox Noisyfox merged commit 3caca22 into SoftFever:main Dec 5, 2024
1 check passed
@Xelinor Xelinor deleted the jerk_limit_warning_fix branch December 5, 2024 00:15
f0x52 pushed a commit to f0x52/OrcaSlicer that referenced this pull request Dec 5, 2024
* Update fdm_process_common.json to use slower jerk settings to prevent belt tooth skipping

* Update fdm_process_anker_fast_common.json for faster jerk settings

* Update Max Jerk limit to be in line with real world machine limits

---------

Co-authored-by: Noisyfox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants