Avoid using auto as type of Eigen expressions.
#8577
Merged
+45
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Noisyfox can you take a look at the conflicts? |
Noisyfox
force-pushed
the
bugfox/eigen-auto
branch
from
27f6621 to
441a7cf
Compare
Noisyfox
force-pushed
the
bugfox/eigen-auto
branch
from
441a7cf to
da64ee9
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://eigen.tuxfamily.org/dox/TopicPitfalls.html one should just avoid using
autoas the type of an Eigen expression.This PR fixes most of them I could found in the project. There might be cases that I missed, and I might update those later if I noticed.
This should prevent issues like #7741 and hopefully fix some mysterious crashes happened inside Eigen calls.