Improve code quality 1

[Schildkroet]

Description

This PR does not add any functional changes. It only improves code quality and fixes serveral compile warnings.

Tests

Tested app overall if i encounter any issues.

Additional testing would be appreciated!

[rubienr]

Hi @Schildkroet,

I would like to help out w.r.t. warnings. Can sb. point me to docs/guidelines where to find the minimal compiler version OrcaSlicher shall support? I guess the code would benefit from C++17 and above.

Just an example:

int ret = fclose(fp);
(void)ret;

vs.

[[maybe_unused]] int ret = fclose(fp);

Btw. I introduced colored compiler output that helps chasing warnings (also better support for ccache to drastically reduce compiling duration) - #8269:

• enables ANSI-colored output for GNU or Clang
• adds -p flag to optionally disable PCH for boosting ccache hit rate

regards, rr

[Schildkroet]

Hello @rubienr
thanks for the input. I updated the source since this feature is supported. Orca Slicer uses C++17.

OT
Why is this project always compiling the whole source? I thought cmake only recompiles changed sources?

[rubienr]

🤔 good Question!

I guess because with BuildLinux.sh it always re-runs CMake hence regenerates cmake files in build directoy. Once you run BuildLinux.sh and you have a build dir, try cd build && ninja all, you will see that it only re-builds modified and its dependencies. Btw it you install ccache (no special configs required) and turn off PCH (precompiled headers) as in #8269 you will benefit any time from ccache you rm -drf build and run BuildLinux.sh.

In your case the simplest way would be to manually turn PCH off and then compile:

sudo apt install ccache

export SLIC3R_PCH=OFF

rm -drf build
# build from scratch; that takes ages; if it runs out of memory re-try again
BuildLinux.sh -s

# while build is running watch ccache hit rate (will grow the 2nd time you run BuildLinux.sh -s or run ninja manually)
watch ccache -svv

# make your code changes
cd build
ninja

# if you are unsure remove build
cd ..
rm -drf build
BuildLinux.sh -s
# now ccache kicks in (new "build" takes about 1minute)

Depending on your available disk space you may want to reduce ccache, because it is then enabled for any compile job (OrcaSlicer takes just 1GB of cache space). My config is quite simple:

cat ~/.ccache/ccache.conf
max_size = 100G