Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale bed icons & text depends on bed size #8621

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented Feb 28, 2025

Scales plate text / icons depends on bed size

BEFORE - buttons impossible to use if bed plate is big - Elegoo OrangeStorm
Screenshot-20250228215240

AFTER- icons always on same size
Screenshot-20250228215220

BEFORE - Icons doesnt fit small plates (105x105) Geetech M1
Screenshot-20250228215539

AFTER- icons scaled to fit
Screenshot-20250228215705

AFTER
Screenshot-20250228220109
Screenshot-20250228220144

CODE CHANGES

• Adding factor to all made code too cluttered. i cleaned up code for commit but i can revert that if you want to keep code same

• Matched code order / format on calc_vertex_for_number, calc_vertex_for_plate_name_edit_icon, calc_vertex_for_icons. but didnt used same format on generate_plate_name_texture . I can clean up it and can use same format on that too if approoved

• Aligned plate name to left of plate, previously there vas a extra spacing that doesnt scales

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch, thank you!

@SoftFever SoftFever merged commit 16cbaf6 into SoftFever:main Mar 1, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants