fixed issue “json minify class is not thread safe, leads to errors on…

… heavy load” https://softinstigate.atlassian.net/browse/RH-233
SoftInstigate · Feb 17, 2017 · 8309af9 · 8309af9
1 parent 4af1045
commit 8309af9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/org/restheart/handlers/ResponseSenderHandler.java b/src/main/java/org/restheart/handlers/ResponseSenderHandler.java
@@ -31,7 +31,6 @@
  * @author Andrea Di Cesare {@literal <[email protected]>}
  */
 public class ResponseSenderHandler extends PipedHttpHandler {
-
     /**
      * @param next
      */
@@ -95,7 +94,7 @@ public void handleRequest(
             }
         }
 
-        if (context.getRepresentationFormat() 
+        if (context.getRepresentationFormat()
                 == RequestContext.REPRESENTATION_FORMAT.HAL) {
             exchange.getResponseHeaders().put(
                     Headers.CONTENT_TYPE, Representation.HAL_JSON_MEDIA_TYPE);

diff --git a/src/main/java/org/restheart/utils/JsonUtils.java b/src/main/java/org/restheart/utils/JsonUtils.java
@@ -545,13 +545,15 @@ public static boolean checkType(Optional<BsonValue> o, String type) {
         }
     }
 
-    private static Minify minifier = new Minify();
-
     /**
      * @param jsonString
      * @return minified json string
      */
     public static String minify(String jsonString) {
+        // Minify is not thread safe. don to declare as static object
+        // see https://softinstigate.atlassian.net/browse/RH-233
+        Minify minifier = new Minify();
+
         if (true) {
             return minifier.minify(jsonString);
         }