ν4.duplication & high cognitive complexity #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainability: - Extracted logic for processing stored file types into processStoredFileTypes method. - Added reusable methods replaceOrAddType and removeTypeByName to reduce code duplication. - Improved readability of fromString method by simplifying its structure. - Eliminated redundant logic in handling removed and modified file types.
…ainability: - Extracted logic for processing stored file types into processStoredFileTypes method. - Added reusable methods replaceOrAddType and removeTypeByName to reduce code duplication. - Improved readability of fromString method by simplifying its structure. - Eliminated redundant logic in handling removed and modified file types.
…ainability: - Extracted logic for processing stored file types into processStoredFileTypes method. - Added reusable methods replaceOrAddType and removeTypeByName to reduce code duplication. - Improved readability of fromString method by simplifying its structure. - Eliminated redundant logic in handling removed and modified file types. Removed unused imports and private fields: - Deleted an unused import statement in line 19. - Removed the unused private field 'name' in line 28.
…maintainability: - Extracted the logic into smaller helper methods (`handlePermutations`, `handleUpdates`, `handleRemovals`, `handleAdditions`) to reduce cognitive complexity. - Added descriptive comments for better understanding of the code. - Simplified the structure by avoiding nested conditions and repetitive logic. - Aligned the method with the Single Responsibility Principle (SRP). This refactoring reduces the cognitive complexity of the method from 24 to below the allowed threshold (15), as reported by SonarQube.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made here: what, why, ...
Link the issue that will be closed, e.g., "Closes JabRef#333". If your PR closes a koppor issue, link it using its URL, e.g., "Closes JabRef#47".
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)