JDE: Added MongoDB insert action + example #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest reponse user properties
|
Please mark whether you used Copilot to assist coding in this PR
|
cyrus2281
changed the title
alimosaed
reviewed
Jan 20, 2025
|
|
||
|
|
||
| class MongoDBInsertComponent(MongoDBBaseComponent): | ||
| """Component for handling MongoDB database operations.""" | ||
|
|
||
| def __init__(self, **kwargs): | ||
| super().__init__(info, **kwargs) | ||
| self.data_types_map = self.get_config("data_types") | ||
|
|
||
| def invoke(self, message, data): |
There was a problem hiding this comment.
Please give some examples of data_types and data. Since the data variable may include any complex data structure (e.g., List[List[List]]), would your code expect to handle all possible combinations?
There was a problem hiding this comment.
Added proper validation.
As for example, you can find some here
gregmeldrum
approved these changes
Jan 20, 2025
alimosaed
reviewed
Jan 20, 2025
| "Invalid data types provided for MongoDB insert. Expected a dictionary." | ||
| ) | ||
| for key, field_type in self.data_types_map.items(): | ||
| if not isinstance(key, str) or not isinstance(field_type, str): |
There was a problem hiding this comment.
[SUG] you can make an enumeration of known data types and compare the filed_type with them. If the type is not know, either raise and error or a warning.
There was a problem hiding this comment.
Added a list with all possible values and a checklist
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
The purpose of this change is to enhance the MongoDB component of the project to support the insertion of data with specified data types. This is important for improving data handling capabilities and ensuring that inserted data conforms to expected formats.
How is this accomplished?
Anything reviews should focus on/be aware of?
Reviewers should ensure that the type conversion implementation is robust, especially the handling of non-JSON types. Also, verify that the MongoDB insert feature is functioning as expected in various scenarios.