DATAGO-93385/DATAGO-93864/Gracefully Terminate the Connector

[alimosaed]

What is the purpose of this change?

The connector does not terminate by a signal when the broker is attempting to connect. The root cause of the problem is that the connector attempts to establish a connection while creating a workflow. So, if it cannot connect, it cannot make the workflow. The current signal can terminate a component; however, no component is created in the above situation.

How is this accomplished?

Added some exception handling to the workflow creation logic and added a signal handling method to trigger an exception.

Anything reviews should focus on/be aware of?

The reviewer can focus on the exception handling solution and any possible edge cases.

[gitstream-cm]

Please mark whether you used Copilot to assist coding in this PR

• Copilot Assisted

[alimosaed]

Changes:

• Added a try-exception around the connection logic.

• Added the below logics to 1) wait till the connection is established 2) raise and exception and exit when a signal is triggered.

       # wait for the connection to complete
        while not self.stop_signal.is_set():
            done, _ = concurrent.futures.wait([result], timeout=0.1)
            if done:
                break
  
        # disconnect and raise an exception if the stop signal is set
        if self.stop_signal.is_set():
            log.error(f"{self.error_prefix} Stopping connection attempt")
            self.disconnect()
            raise KeyboardInterrupt("Stopping connection attempt")
  

[alimosaed]

Changes:

• Added a signal handler to trigger an exception. These exceptions can break the app.run() in any condition (either creating or running the workflow) and consequently calls the Shutdown() method (line #130) to stop and cleanup everything.

[alimosaed]

Changes:

• Added exception handlers and removed duplicate stop and cleanup, as they are called by Shutdown method.

[cyrus2281]

Added a suggestion

The rest looks good

[sonarqube-solacecloud]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication