Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus version upgrade to 3.8.6 #77

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Conversation

SravanThotakura05
Copy link
Collaborator

No description provided.

@SravanThotakura05
Copy link
Collaborator Author

SravanThotakura05 commented Oct 9, 2024

@ozangunalp - Maven Native build is failing when I am upgrading Solace Java Messaging Client to 1.7.0 where as it works with old version 1.4.0. I am not sure if this is an issue with Solace Java Messaging Client Version or Quarkus.

Did you come across any such issue during version migration?

Link to Job - https://github.com/SolaceLabs/solace-quarkus/actions/runs/11236779192/job/31276122526

@ozangunalp
Copy link
Collaborator

@SravanThotakura05 if you wish, let's keep this PR to the Quarkus upgrade to 3.8.6 and baseline to Java 17. I'll check the solace client version update and create an issue/PR.

@ozangunalp
Copy link
Collaborator

ozangunalp commented Oct 10, 2024

@SravanThotakura05 if we baseline to 17 we can remove the Java 11 workflow.

I've opened a PR upstream for the native executable issue. We can add the same fix in the Solace extension for the time being.

@SravanThotakura05
Copy link
Collaborator Author

@ozangunalp - quarkus 3.8.6 will not support java 11 right? Just want to confirm before i remove the workflow

@SravanThotakura05
Copy link
Collaborator Author

@ozangunalp - i have added the change mentioned in your PR. Link to commit - 76d521a

Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. In a future PR we can look at upgrading the Solace client version as discussed in the comments.

@SravanThotakura05 SravanThotakura05 merged commit 6012094 into main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants