Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pages options #11

Merged
merged 2 commits into from
Oct 11, 2018
Merged

feat: support pages options #11

merged 2 commits into from
Oct 11, 2018

Conversation

snadn
Copy link
Contributor

@snadn snadn commented Sep 29, 2018

for #10 . if not need, please close this pr.

@SolarLiner SolarLiner self-requested a review September 29, 2018 10:31
@SolarLiner SolarLiner self-assigned this Sep 29, 2018
@SolarLiner SolarLiner added this to the 1.1.0 milestone Sep 29, 2018
Copy link
Owner

@SolarLiner SolarLiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With multi-page support, the Vue CLI writes multiple HTML files - and content gets duplicated as Vue renders to /page.html and then prerender outputs to /page/index.html.

I think there's more to do here to make it more seamless. Maybe tweak pre-rendering to not create directories but write to [filename].html, or delete the Vue CLI-generated HTML post-process, if that's even possible.

@SolarLiner
Copy link
Owner

Thanks for the work! Merging this now.

@SolarLiner SolarLiner merged commit 0dab81c into SolarLiner:develop Oct 11, 2018
SolarLiner added a commit that referenced this pull request Jan 2, 2019
Version 1.1.0

- Adds support for user post-processing of HTML after pre-rendering #4
- Bundles an `app.html` file which is not prerendered, and should be used as
 entrypoint for non-prerendered routes #14
- Support multi-page mode (by @snadn) #10 (implementation #11)
- Support non-default baseURL (by @snadn) #6 (implementation #9)
- Writes configuration using the API `extendPackage` function, which writes to
 `vue.config.js`. If found, the old configuration will be copied over and
 converted on `vue invoke` (and read, but not converted on build).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants