Merge pull request #121 from solid/fix-tests

Updated linter so test script works
SolidOS · Aug 24, 2021 · 23bf9b5 · 23bf9b5
2 parents f151ae0 + 1942ce6
commit 23bf9b5
Show file tree

Hide file tree

Showing 4 changed files with 118 additions and 50 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -56,8 +56,8 @@
     "@babel/plugin-transform-runtime": "^7.14.5",
     "@babel/preset-env": "^7.14.7",
     "@babel/preset-typescript": "^7.14.5",
-    "@typescript-eslint/eslint-plugin": "^3.10.1",
-    "@typescript-eslint/parser": "^3.10.1",
+    "@typescript-eslint/eslint-plugin": "^4.29.0",
+    "@typescript-eslint/parser": "^4.29.0",
     "babel-core": "^6.26.3",
     "babel-loader": "^8.2.2",
     "bundlesize": "^0.18.1",

diff --git a/src/global/header.ts b/src/global/header.ts
@@ -56,6 +56,9 @@ async function openDashboardPane (outliner: any, pane: string): Promise<void> {
   })
 }
 
+// EventListenerOrEventListenerObject triggers an undefined error in the linter, but it is defined
+// via lib.dom.d.ts
+// eslint-disable-next-line no-undef
 function createUserMenuButton (label: string, onClick: EventListenerOrEventListenerObject): HTMLElement {
   const button = document.createElement('button')
   button.classList.add('header-user-menu__button')

diff --git a/src/helpers/throttle.ts b/src/helpers/throttle.ts
@@ -4,7 +4,7 @@ type ThrottleOptions = {
   trailing?: boolean;
 }
 
-export function throttle (func: Function, wait: number, options: ThrottleOptions = {}): (...args: any[]) => any {
+export function throttle (func: Function, wait: number, options: ThrottleOptions = {}): () => any {
   let context: any,
     args: any,
     result: any