[WIP] Auth Upgrade #420
[WIP] Auth Upgrade #420
Conversation
|
Tests fail because of the dependence on Solid-Logic |
Let the app set the scroll for eyeFocus with window.SolidAppContext.scroll.
fixed ReferenceError: TextEncoder is not defined
Data-Kitchen modification
Data-Kitchen support in authn.ts
src/header/index.ts
Outdated
| const user = session ? sym(session.webId) : null | ||
| return async () => { | ||
| const sessionInfo = authSession.info | ||
| const user = sessionInfo.webId ? sym(sessionInfo.webId) : null |
There was a problem hiding this comment.
I think here is where @jeff-zucker is saying we should use currentUser() instead of sessionInfo.webId as described in https://github.com/solid/solidos/blob/main/documentation/Using_Private_Resources_In_SolidOS.md
There was a problem hiding this comment.
@SharonStrats - yes that is one of the places. Also in the dashboardPane runBuildPage and also in other places. Currently we have these predicates - currentUser, defaultTestUser, offlineID, checkUser - all of which return a webid and are used in various places. This is on top of the places that authSession.webId is called directly. With things like the dashboard it's clear that we don't need to check for an actual session to display the dashboard - it can be on a private no-auth page. Other places in the code are harder to figure whether we need to be checking for the actual session rather than a "acting as logged in". The stuff in Solid Logic in is particularly hard for me to follow.
There was a problem hiding this comment.
@SharonStrats - could you take a look at SolidOS/solid-panes@c9f33b4#diff-c5076b653b08366bc6f16085ac8d0738cba36540a3b06b5f0fb913cdb03e664f - I tried to make the change but something is not right.
app => noAuth webid => webId
Cleanup proptery names for appContext
Authn fix pagejump
Auth Upgrade includes the following libraries: