Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more informative when tap_attach fails #522

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Jul 18, 2022

As it is now the error message when attaching to a tap interface fails does not give any explanation as to why it failed.

solo5-spt: Could not attach interface: temp0

I reviewed the code for tap_attach, and in all paths where -1 is returned either errno is set directly or a previous call will have set it. With this patch strerror(errno) is added at the end of the warning:

solo5-spt: Could not attach interface: temp0: Network is down

Now I know to run ip link set temp0 up :-)

@dinosaure
Copy link
Collaborator

Seems relatively fine for any platform even if FreeBSD11 and OpenBSD6.8 failed.

@dinosaure dinosaure merged commit f6eb867 into Solo5:master Jul 20, 2022
@reynir
Copy link
Contributor Author

reynir commented Jul 20, 2022

Odd. It's unfortunate that there isn't more information on the failed builds. I can't imagine how this change would fail on either platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants