Be more informative when tap_attach fails #522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now the error message when attaching to a tap interface fails does not give any explanation as to why it failed.
I reviewed the code for
tap_attach
, and in all paths where-1
is returned eithererrno
is set directly or a previous call will have set it. With this patchstrerror(errno)
is added at the end of the warning:Now I know to run
ip link set temp0 up
:-)