Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for multiple folders when getting encrypted files #140

Merged
merged 9 commits into from
Apr 2, 2019
Merged

added support for multiple folders when getting encrypted files #140

merged 9 commits into from
Apr 2, 2019

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Apr 1, 2019 •
edited
Loading

close #139

omerlh
omerlh commented Apr 2, 2019
View reviewed changes
init-container/index.js Outdated Show resolved Hide resolved
init-container/index.js Outdated Show resolved Hide resolved
@matan1811 matan1811 requested a review from shaikatz April 2, 2019 12:49
shaikatz
shaikatz suggested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@shaikatz shaikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, please bump major version in the package.json since this is a breaking change to the argument name.

@shaikatz shaikatz merged commit c6aaf31 into master Apr 2, 2019
@shaikatz shaikatz deleted the init-container-multiple-dir branch April 2, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaikatz shaikatz shaikatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init container should accept multiple encrypted directories
3 participants
@omerlh @shaikatz @matan1811