CLI arguments made order invariant #81
Conversation
cli/README.md
Outdated
| @@ -17,17 +17,17 @@ docker run -it --rm soluto/kamus-cli encrypt <arguments> | |||
| ``` | |||
| Or, using kubectl: | |||
| ``` | |||
| kubectl run -it --rm --restart=Never kamus-cli --image=soluto/kamus-cli -- encrypt <arguments> | |||
| kubectl run -it --rm --restart=Never kamus-cli --image=**soluto**/kamus-cli -- encrypt <arguments> | |||
cli/index.js
Outdated
| .argument('<namespace>', 'Deployment namespace') | ||
| .action(encrypt) | ||
| .action(encrypt) | ||
| .option('--secret <data>','Data to encrypt', prog.REQUIRED) |
There was a problem hiding this comment.
This makes the arguments global options, and not only for the encrypt commands - correct? Isn't it weird?
There was a problem hiding this comment.
I don't think it makes the arguments global. I chained another command method and didn't see that arguments in the second command help.
Only arguments or options that are set before the first command method are global.
There was a problem hiding this comment.
So if what you're saying is true - all these:
.option('--kamus-url <url>', 'Kamus URL', prog.REQUIRED)
Should move up before the first command...
| .option('--auth-tenant <id>', 'Azure tenant id', regexGuid) | ||
| .option('--auth-application <id>', 'Azure application id', regexGuid) | ||
| .option('--auth-resource <name>', 'Azure resource name', prog.STRING) | ||
| .option('--kamus-url <url>', 'Kamus URL', prog.REQUIRED) |
There was a problem hiding this comment.
I prefer to keep it shorter - kamus-url
cli/index.js
Outdated
| .argument('<namespace>', 'Deployment namespace') | ||
| .action(encrypt) | ||
| .action(encrypt) | ||
| .option('--secret <data>','Data to encrypt', prog.REQUIRED) |
There was a problem hiding this comment.
So if what you're saying is true - all these:
.option('--kamus-url <url>', 'Kamus URL', prog.REQUIRED)
Should move up before the first command...
| .post('/api/v1/encrypt', { data, ['service-account']: serviceAccount, namespace}) | ||
| .reply(200, '123ABC'); | ||
| }); | ||
|
|
||
| it('Should return encrypted data', async () => { | ||
| await encrypt({data, serviceAccount, namespace, kamusApiUrl}, logger); | ||
| await encrypt(null, {data, serviceAccount, namespace, kamusUrl}, logger); |
There was a problem hiding this comment.
caporal calls the action with 3 parameters: args, options, logger.
I removed the first parameter by mistake because we don't actually use it. But the order matters.
Closes #77