-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESLint plugin type dependencies #4782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copied reproducer from alecmev@ad6e8f7 Thanks @alecmev for your help |
ericmorand-sonarsource
force-pushed
the
fix-eslint-dependencies
branch
2 times, most recently
from
August 28, 2024 15:19
97e102a
to
cbd3efa
Compare
ericmorand-sonarsource
force-pushed
the
fix-eslint-dependencies
branch
from
August 28, 2024 18:15
cbd3efa
to
45db117
Compare
Quality Gate passedIssues Measures |
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned ericmorand-sonarsource
Aug 29, 2024
vdiez
commented
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thx Eric!
ericmorand-sonarsource
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.