Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-329 Upgrade TypeScript to 5.6.2 #4816

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,8 @@
- npm run build:fast
- npm run update-ruling-data
- npm run ruling -- --maxWorkers=8
on_failure:
debug_script: diff -rq its/ruling/src/test/expected/jsts packages/ruling/tests/actual/jsts
cleanup_before_cache_script: cleanup_maven_repository

eslint_plugin_test_task:
Expand Down Expand Up @@ -365,7 +367,7 @@
path: 'its/perf/target/perf.txt'
cleanup_before_cache_script: cleanup_maven_repository

promote_task:

Check warning on line 370 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L370

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 370 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L370

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 370 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L370

task "promote" depends on task "ws_scan", but their only_if conditions are different
depends_on:
- ws_scan
- build_win
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void test() {
)
)
.isEmpty();
assertThat(buildResult.getLogsLines(l -> l.contains("TS API in custom rule: TS version 5.4.3")))
assertThat(buildResult.getLogsLines(l -> l.contains("TS API in custom rule: TS version 5.6.2")))
.hasSize(2);
List<Issue> issues = findIssues("eslint-custom-rules:sqKey", orchestrator);
assertThat(issues).hasSize(2);
Expand Down
12 changes: 0 additions & 12 deletions its/ruling/src/test/expected/jsts/TypeScript/typescript-S4325.json
Original file line number Diff line number Diff line change
Expand Up @@ -316,20 +316,8 @@
],
"TypeScript:src/harness/harness.ts": [
36,
743,
1102
],
"TypeScript:src/harness/harnessLanguageService.ts": [
151,
190
],
"TypeScript:src/harness/virtualFileSystem.ts": [
45,
50,
69,
152,
170
],
"TypeScript:src/server/editorServices.ts": [
1123
],
Expand Down
6 changes: 6 additions & 0 deletions its/ruling/src/test/expected/jsts/ace/typescript-S1874.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"ace:demo/kitchen-sink/docs/typescript.ts": [
35,
46
ilia-kebets-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
144
],
"ant-design:components/anchor/Anchor.tsx": [
27,
258
ilia-kebets-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
27
],
"ant-design:components/anchor/__tests__/Anchor.test.tsx": [
61,
Expand Down Expand Up @@ -129,9 +128,6 @@
"ant-design:components/mentions/index.tsx": [
142
],
"ant-design:components/message/index.tsx": [
107
],
"ant-design:components/popconfirm/index.tsx": [
152
],
Expand Down Expand Up @@ -167,8 +163,9 @@
"ant-design:components/tag/index.tsx": [
55
],
"ant-design:components/timeline/Timeline.tsx": [
48
"ant-design:components/time-picker/index.tsx": [
72,
74
],
"ant-design:components/transfer/__tests__/dropdown.test.tsx": [
54,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
217
],
"ant-design:components/descriptions/index.tsx": [
38,
76
],
"ant-design:components/form/FormItem.tsx": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,8 @@
"courselit:apps/web/components/admin/media/media-preview.tsx": [
98
],
"courselit:apps/web/components/admin/settings.tsx": [
310
],
"courselit:apps/web/pages/api/payment/initiate.ts": [
55,
65
],
"courselit:apps/web/payments/stripe-payment.ts": [
72
]
}
3 changes: 0 additions & 3 deletions its/ruling/src/test/expected/jsts/eigen/typescript-S1874.json
Original file line number Diff line number Diff line change
Expand Up @@ -1539,9 +1539,6 @@
"eigen:src/app/tests/renderRelayTree.tsx": [
105
],
"eigen:src/app/tests/renderUntil.tsx": [
38
],
"eigen:src/app/tests/renderWithLayout.tsx": [
1,
6
Expand Down
59 changes: 3 additions & 56 deletions its/ruling/src/test/expected/jsts/eigen/typescript-S4325.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,21 +61,16 @@
44
],
"eigen:src/app/Components/Bidding/BidFlow.tests.tsx": [
34,
55
],
"eigen:src/app/Components/Bidding/Helpers/FakeNavigator.tsx": [
39
],
"eigen:src/app/Components/Bidding/Screens/ConfirmBid.tests.tsx": [
43
],
"eigen:src/app/Components/Bidding/Screens/ConfirmBid/index.tsx": [
601,
613
],
"eigen:src/app/Components/Bidding/Screens/Registration.tests.tsx": [
28,
151,
161,
763,
Expand Down Expand Up @@ -111,9 +106,6 @@
"eigen:src/app/Components/PartnerEntityHeader.tsx": [
25
],
"eigen:src/app/Components/ReadMore.tsx": [
49
],
"eigen:src/app/Components/ShareSheet/ShareSheet.tsx": [
75
],
Expand Down Expand Up @@ -155,7 +147,6 @@
49
],
"eigen:src/app/Scenes/Artwork/Components/PartnerCard.tsx": [
98,
113
],
"eigen:src/app/Scenes/AuctionBuyersPremium/AuctionBuyersPremium.tests.tsx": [
Expand All @@ -164,15 +155,9 @@
"eigen:src/app/Scenes/BottomTabs/BottomTabsButton.tsx": [
63
],
"eigen:src/app/Scenes/City/Components/Event/index.tests.tsx": [
10
],
"eigen:src/app/Scenes/City/Components/Event/index.tsx": [
159
],
"eigen:src/app/Scenes/City/Components/TabFairItemRow/index.tests.tsx": [
12
],
"eigen:src/app/Scenes/City/Components/TabFairItemRow/index.tsx": [
32
],
Expand Down Expand Up @@ -220,10 +205,6 @@
"eigen:src/app/Scenes/Inbox/Components/ActiveBids/index.tsx": [
42
],
"eigen:src/app/Scenes/Inbox/Components/Conversations/Conversations.tsx": [
74,
75
],
"eigen:src/app/Scenes/Inbox/Components/Conversations/InquiryMakeOfferButton.tests.tsx": [
41
],
Expand Down Expand Up @@ -275,9 +256,6 @@
50,
51
],
"eigen:src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionArtworkHeader.tsx": [
81
],
"eigen:src/app/Scenes/MyCollection/Screens/ArtworkForm/MyCollectionArtworkForm.tests.tsx": [
39
],
Expand Down Expand Up @@ -311,18 +289,9 @@
"eigen:src/app/Scenes/Onboarding/OnboardingPersonalization/OnboardingPersonalizationModal.tsx": [
230
],
"eigen:src/app/Scenes/OrderHistory/OrderDetails/Components/OrderDetailsHeader.tsx": [
20
],
"eigen:src/app/Scenes/OrderHistory/OrderDetails/Components/OrderDetailsPayment.tsx": [
20
],
"eigen:src/app/Scenes/OrderHistory/OrderDetails/Components/TrackOrderSection.tsx": [
24
],
"eigen:src/app/Scenes/OrderHistory/OrderHistoryRow.tsx": [
20
],
"eigen:src/app/Scenes/Sale/Components/BuyNowArtworksRail.tsx": [
33
],
Expand Down Expand Up @@ -437,17 +406,13 @@
"eigen:src/app/navigation/NavStack.tsx": [
33
],
"eigen:src/app/navigation/routes.tsx": [
31
],
"eigen:src/app/relay/middlewares/cacheMiddleware.ts": [
22,
27,
35
],
"eigen:src/app/relay/middlewares/errorMiddleware.ts": [
22,
24,
32
],
"eigen:src/app/relay/middlewares/metaphysicsMiddleware.ts": [
Expand All @@ -459,6 +424,9 @@
"eigen:src/app/utils/experiments/unleashClient.ts": [
50
],
"eigen:src/app/utils/hideBackButtonOnScroll.tests.tsx": [
15
],
"eigen:src/app/utils/renderWithLoadProgress.tests.tsx": [
9,
17
Expand All @@ -472,31 +440,10 @@
85,
88
],
"eigen:src/app/utils/track/SegmentTrackingProvider.ts": [
52,
64,
72,
79,
86,
94
],
"eigen:src/app/utils/useImageSearch.ts": [
100
],
"eigen:src/palette/Theme.tsx": [
278
],
"eigen:src/palette/atoms/Spacer/Spacer.stories.tsx": [
23,
43
],
"eigen:src/palette/elements/PhotoRow/PhotoRow.tests.tsx": [
13
],
"eigen:src/palette/helpers/color.tests.tsx": [
9
],
"eigen:src/palette/helpers/space.tests.tsx": [
10
]
}
19 changes: 0 additions & 19 deletions its/ruling/src/test/expected/jsts/vuetify/typescript-S1874.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,9 @@
45,
46
],
"vuetify:packages/vuetify/src/components/VDataIterator/VDataIterator.ts": [
167,
171
],
"vuetify:packages/vuetify/src/components/VDatePicker/VDatePicker.ts": [
179
],
"vuetify:packages/vuetify/src/components/VDatePicker/util/createNativeLocaleFormatter.ts": [
38
],
"vuetify:packages/vuetify/src/components/VDatePicker/util/isDateAllowed.ts": [
8
],
"vuetify:packages/vuetify/src/components/VDatePicker/util/sanitizeDateString.ts": [
7
],
"vuetify:packages/vuetify/src/components/VOtpInput/VOtpInput.ts": [
245
],
"vuetify:packages/vuetify/src/components/VStepper/VStepperStep.ts": [
139
],
"vuetify:packages/vuetify/src/composables/theme.ts": [
335
],
Expand Down
31 changes: 16 additions & 15 deletions its/ruling/src/test/expected/jsts/vuetify/typescript-S4325.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"vuetify:packages/vuetify/cypress/support/mount.ts": [
32
],
"vuetify:packages/vuetify/src/components/VCalendar/mixins/mouse.ts": [
100
],
"vuetify:packages/vuetify/src/components/VData/VData.ts": [
382
],
Expand Down Expand Up @@ -29,9 +32,18 @@
55,
57
],
"vuetify:packages/vuetify/src/components/VRangeSlider/VRangeSlider.tsx": [
95
],
"vuetify:packages/vuetify/src/components/VSelectionControl/__tests__/VSelectionControl.spec.tsx": [
17
],
"vuetify:packages/vuetify/src/components/VStepper/VStepper.ts": [
109,
111,
112,
119
],
"vuetify:packages/vuetify/src/components/VTextarea/VTextarea.tsx": [
163,
179
Expand All @@ -50,14 +62,12 @@
25,
65
],
"vuetify:packages/vuetify/src/composables/forwardRefs.ts": [
66
],
"vuetify:packages/vuetify/src/composables/proxiedModel.ts": [
47
"vuetify:packages/vuetify/src/composables/router.tsx": [
53
],
"vuetify:packages/vuetify/src/composables/theme.ts": [
237
237,
310
],
"vuetify:packages/vuetify/src/composables/transition.ts": [
27,
Expand All @@ -69,17 +79,8 @@
38,
42
],
"vuetify:packages/vuetify/src/framework.ts": [
131
],
"vuetify:packages/vuetify/src/util/defineComponent.tsx": [
195
],
"vuetify:packages/vuetify/src/util/helpers.ts": [
121,
123
],
"vuetify:packages/vuetify/src/util/useRender.ts": [
8
]
}
Loading