Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE - Nullable: Add UTs for Debug.Assert #6956

Merged
merged 4 commits into from
Mar 27, 2023
Merged

SE - Nullable: Add UTs for Debug.Assert #6956

merged 4 commits into from
Mar 27, 2023

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Part of #6812

Add UTs to make sure we learn from Debug.Assert

@pavel-mikula-sonarsource pavel-mikula-sonarsource force-pushed the Pavel/SE/12-RecursivePattern branch from 11e20f6 to 7d8ae7d Compare March 20, 2023 12:53
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more test cases.

...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs Show resolved Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs Show resolved Hide resolved
Base automatically changed from Pavel/SE/12-RecursivePattern to feature/SE March 21, 2023 13:34
@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review March 21, 2023 13:35
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NotNullConstraint is missing in the True/False case.

...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs Show resolved Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs Show resolved Hide resolved
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find one test case that should have changed.

...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs Show resolved Hide resolved
...ts/SonarAnalyzer.UnitTest/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 061ef81 into feature/SE Mar 27, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/SE/13-DebugAssert branch March 27, 2023 09:37
pavel-mikula-sonarsource added a commit that referenced this pull request Mar 28, 2023
@pavel-mikula-sonarsource
SE - Nullable: Add UTs for Debug.Assert (#6956)
41cc7cf
pavel-mikula-sonarsource added a commit that referenced this pull request Mar 31, 2023
@pavel-mikula-sonarsource
SE - Nullable: Add UTs for Debug.Assert (#6956)
afcc682
pavel-mikula-sonarsource added a commit that referenced this pull request Apr 4, 2023
@pavel-mikula-sonarsource
SE - Nullable: Add UTs for Debug.Assert (#6956)
963c767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-mikula-sonarsource @martin-strecker-sonarsource