Update ITs to always use the latest version of the Scanner for .NET #8439
Conversation
its/pom.xml
Outdated
| @@ -20,7 +20,7 @@ | |||
| </organization> | |||
|
|
|||
| <properties> | |||
| <scannerMsbuild.version>5.15.0.80890</scannerMsbuild.version> | |||
| <scannerMsbuild.version>6.0.0.81631</scannerMsbuild.version> | |||
There was a problem hiding this comment.
I think we should discuss the "how" of the current sprint before making these changes. One valid approach to avoid in the future this kind of commits is to always download the latest released version.
antonioaversa
changed the title
costin-zaharia-sonarsource
force-pushed
the
antonio/bump-s4net-6.0.0.81631
branch
6 times, most recently
from
6aa5b13 to
603264a
Compare
| <artifactId>sonar-scanner-msbuild</artifactId> | ||
| <version>${scannerMsbuild.version}</version> | ||
| <type>zip</type> | ||
| <classifier>net46</classifier> |
There was a problem hiding this comment.
@costin-zaharia-sonarsource
Educational: was this dependency there to ensure that the zip was locally available for the orchestrator to use it? Or it was unnecessary, since the orchestrator was retrieving the zip of the scanner by itself anyway?
There was a problem hiding this comment.
I do not know. I suspect it was a leftover; probably, it was installed from a local path at some point and then, the code changed and the configuration remained forgotten.
| <version>3.6.1</version> | ||
| <executions> | ||
| <execution> | ||
| <id>get-scanner-2.1</id> |
There was a problem hiding this comment.
@costin-zaharia-sonarsource
Educational: I guess the <type>zip</type> above, in the sonar-scanner-msbuild dependency, was not enough to get the zip of the scanner?
There was a problem hiding this comment.
I do not know. This seems to be very old. My understanding is that it wasn't used/needed anymore.
| <artifactId>sonar-scanner-msbuild</artifactId> | ||
| <groupId>org.sonarsource.scanner.msbuild</groupId> | ||
| <packaging>zip</packaging> | ||
| <version>2.1.0.0</version> |
There was a problem hiding this comment.
@costin-zaharia-sonarsource
Educational: It is unclear to me what is the relation between this <configuration> element, which refers to version 2.1.0.0, and the dependency element above, which refers to <version>${scannerMsbuild.version}</version>, so to 5.15.0.80890 (in the previous version of the code).
Was version 2.1.0.0 incorrect, and overridden by the dependency element, so not used by the maven-dependency-plugin to perform the download?
There was a problem hiding this comment.
I do not know. This seems to be very old. My understanding is that it wasn't used/needed anymore. Probably configuration changed and this was forgotten.
costin-zaharia-sonarsource
force-pushed
the
antonio/bump-s4net-6.0.0.81631
branch
from
603264a to
defc81f
Compare
github-actions
bot
assigned antonioaversa and unassigned antonioaversa and costin-zaharia-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
costin-zaharia-sonarsource
changed the title
Co-authored-by: Costin Zaharia <[email protected]>
Bump S4NET to latest (6.0.0.81631)
The 6.0.0.81631 release of the S4NET is a major version release, introducing several breaking changes that need to be tested with
sonar-dotnetITs.The PR stays in draft for the time being, since we may not need this if we successfully run on the latest S4NET.The work to run on the latest S4NET, instead of a fixed version, will be done in the context of SonarSource/sonar-scanner-msbuild#1774The first commit of the PR, authored by @antonioaversa, was only for testing of 6.0.0.81631 in
sonar-dotnet.The final version of the PR authored by @costin-zaharia-sonarsource, taking advantage of the new "latest version" feature of the orchestrator, is done in this commit and this commit.