Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale in the ticket
Only build dependencies so there shouldn't be a risk for users.
Debt
What was done
- Gulp upgraded tov5
fromv4
-merge-stream
replaced byordered-read-stream
becausemerge-stream
doesn't work with gulp v5del
dropped in favor using directly one of its dependenciesrimraf
becausedel
is now ESM onlyglobby
dropped in favor ofglob
for the same reasongulp-collect
cleaned up (not used)gulp-util
dropped in favor offancy-log
(one of its dependencies) (doc)eslint @ 8
(latest:9
) because eslint plugins arn't compatible with v9 yetdateformat @ 4
(latest:5
) because v5 is ESM onlygulp @ 4
(latest:5
)Next step
There still are some things to do, I had to cut the branch due to some issues:
merge-stream
is broken withv5
andordered-streams
does not work out of the box as wellgulp-artifactory-upload
should be dropped in favor of manual call toaxios
,node-fetch
orfetch
gulp-download
should be dropped in favor of manual call toaxios
,node-fetch
orfetch
This will
gulp-util
transitive dependency (gulp-download
)request
transitive dependency (gulp-artifactory-upload
andgulp-download
)braces
to 3+ (gulp
)