Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANMAVEN-210: Move to Java 11 #220

Merged
merged 3 commits into from
May 16, 2024

Conversation

ADarko22
Copy link
Contributor

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (MSONAR-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

@ADarko22 ADarko22 marked this pull request as ready for review May 14, 2024 15:48
@ADarko22 ADarko22 force-pushed the angelo/SCANMAVEN-210_move_to_java_11 branch from 8110695 to 1089690 Compare May 15, 2024 07:13
@ADarko22 ADarko22 force-pushed the angelo/SCANMAVEN-210_move_to_java_11 branch from 1089690 to 7019ed9 Compare May 15, 2024 09:10
@ADarko22 ADarko22 requested a review from leveretka May 15, 2024 13:18
Copy link
Contributor

@leveretka leveretka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine with the migration itself, but we might have new issues on Next raised, so it will be nice to fix them.

I think that should be fine to do it after merge.

Copy link

@leveretka leveretka self-requested a review May 16, 2024 09:44
@leveretka leveretka merged commit dd5762e into master May 16, 2024
18 checks passed
@leveretka leveretka deleted the angelo/SCANMAVEN-210_move_to_java_11 branch May 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants