Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to scan subdirs of Maven and Gradle projects separately #19

Merged

Conversation

workshur
Copy link
Contributor

@workshur workshur commented Mar 17, 2021

In our case (https://github.com/provectus/kafka-ui), the ReactJS application is part of the maven project / monorepo.
This update allows us to check quality of js app separately.

@marktarry-mobysoft
Copy link

We've got a similar issue - where we have a monorepo which also contains a Maven project.

While #29 would technically make it possible to use this action, the change proposed here seems more adaptable to the monorepo use-case.

@akash-jain-10
Copy link

We also have the same issue which is block us to us this amazing Github Action for Yarn Project under a Maven Project MonoRepo. Let us know if we can help get this reviewed, merged and published on master! Thanks.

@workshur
Copy link
Contributor Author

Hello @tom-vanbraband-sonarsource
do you have any suggestions for improvement? How can we promote this PR and get a review?

@workshur workshur changed the title Add an ability to sonar subdirs of Maven and Gradle projects separately Add an ability to scan subdirs of Maven and Gradle projects separately Apr 27, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, and apologies for the very late response on our side.
The change looks good!

@tom-vanbraband-sonarsource tom-vanbraband-sonarsource merged commit 156db6f into SonarSource:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants