Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounded corners to cover art #156

Merged

Conversation

vixalien
Copy link
Contributor

No description provided.

@SoongNoonien
Copy link
Owner

Thanks for your effort, but I'm not sure if I like that. With covers which aren't square this isn't working correctly. Also Gtk.Picture seems to be incompatible with this change. Here are two screenshots of the same cover, one screenshot is from the album list using Gtk.Picture and the other is from the album page using Gtk.Image:
Bildschirmfoto vom 2024-10-30 17-07-01
Bildschirmfoto vom 2024-10-30 17-07-11

@vixalien
Copy link
Contributor Author

With covers which aren't square this isn't working correctly.

Can you show me, I don't have covers that aren't square.

Here are two screenshots of the same cover, one screenshot is from the album list using Gtk.Picture and the other is from the album page using Gtk.Image

You're right. I don't know why but it seems like Gtk.Picture doesn't work that well with rounded corners. I will investigate.

@vixalien
Copy link
Contributor Author

I have fixed the Gtk.Picture looking weird when rounded. Can I see how it looks like for non-square covers?

@SoongNoonien
Copy link
Owner

Here are two covers side by side, one square and one slightly wider than tall:
Bildschirmfoto vom 2024-10-30 18-35-51

@vixalien
Copy link
Contributor Author

The picture probably needs valign=CENTER too. It would be nice if you can check if that fixes it as I don't have a non-square cover.

@SoongNoonien
Copy link
Owner

I thought so too, but this makes the square covers look broken again.
Bildschirmfoto vom 2024-10-30 19-02-12

@SoongNoonien
Copy link
Owner

Also vertical covers which worked before with just halign=Gtk.Align.CENTER are broken again now too.
Bildschirmfoto vom 2024-10-30 19-03-24

@SoongNoonien SoongNoonien self-assigned this Oct 31, 2024
@SoongNoonien
Copy link
Owner

Apparently I'm not allowed to push to your branch?

@SoongNoonien
Copy link
Owner

Oh, I am sorry!

@SoongNoonien SoongNoonien force-pushed the wip/vixalien/rounded-corners branch from 382225c to 679f38f Compare October 31, 2024 15:39
@SoongNoonien
Copy link
Owner

This is all I can do right now. Everything is working except for tall covers in the list.

@SoongNoonien SoongNoonien force-pushed the wip/vixalien/rounded-corners branch from c04e38c to e140b9f Compare November 1, 2024 10:14
@SoongNoonien
Copy link
Owner

Ok, I found the problem and everything should be fixed now.

@SoongNoonien SoongNoonien merged commit 06a664e into SoongNoonien:master Nov 1, 2024
1 check passed
@vixalien vixalien deleted the wip/vixalien/rounded-corners branch November 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants