Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MPD_HOST/_PORT environment variables #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jspricke
Copy link

No description provided.

@SoongNoonien
Copy link
Owner

Hi!
Thanks for the PR. I don't think that it is desirable to modify the settings via the environment variables. I could imagine to give them priority over the settings of Plattenalbum.

@jspricke
Copy link
Author

Thanks for the feedback, changed the patch accordingly.

@SoongNoonien
Copy link
Owner

Thanks for the update. But you broke the connect process. It is now impossible to connect via a socket if the host gsettings entry is nonempty. Also running self.config() without any safety precautions can crash the whole program.

@jspricke
Copy link
Author

pushed a new version. The only thing I noticed when testing was that you can't connect to a different remote host when $MPD_HOST is set. To allow this we would need to make remote-connection three state or add an extra variable. I don't have enough experience with gi to know the implications, do you have some insights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants