Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the request spec helper method, #login_user. #57

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Add the request spec helper method, #login_user. #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c265b7a
Add the request spec helper method, #login_user.
ebihara99999 Apr 22, 2017
3ca02f0
Fix codacy failure because of `Redundant `self` detected.`
ebihara99999 Feb 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/sorcery.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ module TestHelpers
module Rails
require 'sorcery/test_helpers/rails/controller'
require 'sorcery/test_helpers/rails/integration'
require 'sorcery/test_helpers/rails/request'
end

module Internal
Expand Down
20 changes: 20 additions & 0 deletions lib/sorcery/test_helpers/rails/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module Sorcery
module TestHelpers
module Rails
module Request
# Accepts arguments for user to login, the password, route to use and HTTP method
# Defaults - @user, 'secret', 'user_sessions_url' and http_method: POST
def login_user(user = nil, password = 'secret', route = nil, http_method = :post)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if secret being the password default makes the most sense here...I can't think of anything that would make more sense off the top of my head though, so I think it should be fine for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the password default value. I added modification from Integration#login, which forces us to use ‘secret’. I don’t think the deafault value isn’t needed because what is really needed is to choose the password value, and I will remove the value if necessary.

user ||= @user
route ||= user_sessions_url

username_attr = user.sorcery_config.username_attribute_names.first
username = user.send(username_attr)
password_attr = user.sorcery_config.password_attribute_name

send(http_method, route, params: { "#{username_attr}": username, "#{password_attr}": password })
end
end
end
end
end