Added hotkey EDIT: (ctrl+H) to like/favorite track. closes #716 #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done using triggerHandler on ".player_favorite"
weblancaster
changed the title
|
Currently, the shortcut CTRL+L "locks" the track, you may wanna look into that |
|
@zestyr is right @mathiash98 you will need to change that |
|
I'd suggest Ctrl+H, since it isn't taken, and it's H as in Heart |
|
@zestyr @weblancaster edited to ctrl+H now |
mathiash98
changed the title
| combo: ['command+h', 'ctrl+h'], | ||
| description: 'Heart track', | ||
| callback: function() { | ||
| $timeout(function() { |
There was a problem hiding this comment.
I have no idea, I just copied your code from another function. @weblancaster
There was a problem hiding this comment.
Hm I checked not sure why we have that timeout over there.. please remove and test again if works just leave the $timeout out and I will merge.. thanks
|
@mathiash98 agreed, this is implementation is very important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by another user. issue #716
Done using triggerHandler on ".player_favorite"