NW.js to Electron.js migration #894

weblancaster · 2016-10-14T18:45:56Z

I might be forgetting something so I'm going to add as I go.

…, load vendors using npm

ghost · 2016-10-14T19:44:09Z

When this is done, can we finally stop using sc-redirect.herokuapp.com?

weblancaster · 2016-10-14T19:44:54Z

and use what @wb9688 ?

ghost · 2016-10-14T19:46:54Z

I don't know, the authentication part that's currently in Soundnode always looked like a hack to me…

weblancaster · 2016-10-14T21:10:49Z

It is a hack.. but there is no other way because Soundcloud expect the third party to have a domain.

…uthenticated, wip

bardiharborow · 2016-10-16T05:44:12Z

I came here to look at what's being done, but the changes are cluttered by a huge amount of style changes. Is there a reason these are included in this particular PR?

weblancaster · 2016-10-16T16:07:08Z

@bardiharborow I updated the editorconfig file so now the design of line spaces is different, if that's what you are asking though.

- All nw.js references are now replaced - Angular app can bootstrap - Code refactoring was done to get modules loading correctly. - Replace custom window management to a third party module removing the need to do it "manually".

- Remove all grunt tasks - Add npm script tasks - Remove jshint since eslint is being used

- Fix window/app action buttons - Improve webpack config

weblancaster · 2016-10-30T22:35:47Z

@wb9688 @Pitros @jakejarrett It's all migrated but would be nice if any of you could test it out.
I will be testing today and tomorrow.

Here are the files for Mac, Win and Linux https://www.dropbox.com/sh/vkyq4jbr9ol1mpg/AABHzCFPoFHes8G_Y5k2Fy9Va?dl=0 (the rate limit is being reached pretty easily this days though so you might have issues playing tracks)

To build locally you just need to run npm run build if you are notusing windows you will need to install wine https://www.davidbaumgold.com/tutorials/wine-mac/

that's it. thanks.

jakejarrett · 2016-10-30T22:52:03Z

@weblancaster on linux build, i am unable to use some custom shortcuts that were previously present (Scaling & devtools)

ghost · 2016-10-31T05:37:20Z

@weblancaster: I'll try it when I've time, but I can always manually set the API keys in the localStorage to my own ones…

weblancaster · 2016-10-31T15:30:00Z

@jakejarrett hm yeah I removed some shortcuts and did not notice, I'm going to add back once I get a chance.

weblancaster · 2016-11-05T00:23:11Z

@wb9688 @Pitros @jakejarrett I have updated the build on dropbox if you are not building locally.

@jakejarrett the scale down/up works normally on mac

SW1FT · 2016-11-05T00:35:38Z

@weblancaster I just tried the Win build but I can't seem to be able to login. It just shows a white rectangle popup along with another white box popup saying "This popup should automatically close in a few seconds" after entering my SC account details.

weblancaster · 2016-11-05T00:42:43Z

@SW1FT I'm going to check here

TheNightRider12 · 2016-12-16T21:18:14Z

@wb9688 I will let you know when I get home from school. Give me about 2hrs

TheNightRider12 · 2016-12-16T21:19:27Z

@jakejarrett I will give That a try when I get home from school

weblancaster · 2016-12-17T01:56:59Z

@Legitgamer264 try log out and then log back in. The ngModel:numfmtwill show up but you will be able to login.

TheNightRider12 · 2016-12-17T02:11:40Z

@weblancaster I am able to get the Minimize, X, and settings, etc buttons to appear. But I still can't play any track. Is this still because of the API? It's been a few days since I was able to play a track

ghost · 2016-12-17T07:46:13Z

@Legitgamer264: Soundnode doesn't use the localStorage for getting the Client ID and Access Token in this Electron version, instead it uses the following code:

const fs = require('fs');
const userConfig = JSON.parse(fs.readFileSync(`${__dirname}/userConfig.json`, 'utf-8'));

// set window access token
window.scAccessToken = userConfig.accessToken;

// set window clientId
window.scClientId = userConfig.clientId

Which means there's a userConfig.json file that stores the Client ID and Access Token…

Btw don't share your Access Token, because then everyone is able to log in as you…

weblancaster · 2016-12-17T07:49:16Z

@Legitgamer264 yes usually by 3pm CST Soundnode reached the API limit already so then just in the next day.

Weekends not as much people use so you will be able to use for longer (mostly during the mornings and beginning of the afternoon).

ghost · 2016-12-17T08:11:28Z

@weblancaster: Can you make npm run clean able to run on Windows? Windows doesn't have the rm command, so you should use something like rimraf…

weblancaster · 2016-12-17T18:28:52Z

@wb9688 good point.. going to do that today. thanks.

TheNightRider12 · 2016-12-17T19:47:38Z

@wb9688 do you have any idea when your python script will be fixed to work with the electron build?

weblancaster · 2016-12-17T21:41:00Z

@Legitgamer264 try changing the clientId here with yours https://github.com/Soundnode/soundnode-app/blob/electron-migration/main.js#L14

TheNightRider12 · 2016-12-17T23:25:44Z

@weblancaster I got it to work. But you have to also change app/public/js/system/userConfig.json, and put in the AccessToken and ClientId in that file too. That along with changing the clientID in main.js will work

weblancaster · 2016-12-18T02:15:23Z

@Legitgamer264 I'm adding the accessToken and clientId to userConfig.json.

You can take a look here https://github.com/Soundnode/soundnode-app/blob/electron-migration/main.js#L73

#923), remove not in use code, improve ngDialog styles, fix js error on showMoreDirective.

weblancaster · 2016-12-19T09:08:18Z

I have pushed new commits so if anyone wants to test please pull latest. thanks.

TheNightRider12 · 2016-12-19T17:07:09Z

I will pull the latest when I get home

TheNightRider12 · 2016-12-19T20:09:33Z

@weblancaster When I logged out and went to sign back in, I get this window - http://i.imgur.com/pw3JiNP.png
I checked and the userConfig.json is not in app/public/js/system
but I looked into the main.js and if I have the general idea of the code, if the userConfig doesn't exist isn't it supposed to open up the authentication window?

TheNightRider12 · 2016-12-19T20:18:55Z

@wb9688 so what would the script be to get the clientID and accessToken for the electron build? since that is the one I am using at this time

ghost · 2016-12-19T20:27:38Z

@Legitgamer264: The Python script is always the same, because it just gets some tokens from SoundCloud, but the place where you need to paste the tokens is different in this Electron build, I haven't yet had the time to look at the Electron build, so you should ask @weblancaster where to place them, btw tomorrow I'll _probably_ make a patch for the Electron build à la my patch for the "old" Soundnode…

TheNightRider12 · 2016-12-19T20:29:33Z

@wb9688 thank you. I have ran the script and copied the access token and clientID into the userConfig, and I changed the clientID in the main.js file too but whenever I package the app up and then run the exe, I still get the API limit error. idk what I am doing wrong

ghost · 2016-12-19T20:46:21Z

@Legitgamer264: The errors show a Client ID in the URLs, is that one the same as the one you just copied from my Python script?

TheNightRider12 · 2016-12-19T21:06:46Z

@wb9688 I am using the same clientID that I get from your script. Same with the access token. I put the accessToken and ClientID in the userConfig located in (for me) soundnode-app\dist\Soundnode\Soundnode-win32-x64\resources\app\app\public\js\system

TheNightRider12 · 2016-12-19T23:20:52Z

@weblancaster I think I found the issue on why the clientID and accesstokens that I get from the python script aren't working. I tried the build on my laptop, before the update on 12/19, and I was able to play songs just fine. But when I pulled the latest electron from today, that is when I got the API limit error. I am not sure which of the changes that were made that caused it to not work. But I know its the latest update from today that is causing it. I am pretty sure of that.
Edit - my laptop is on the electron build, just not the latest one. my desktop is on the latest electron and that is causing the issue

kokarn · 2016-12-20T07:48:14Z

Pretty sure it's just the keys that are limited because of the number of plays. Nothing to do with Electron or NW

…

On Tue, Dec 20, 2016 at 12:20 AM Legitgamer264 ***@***.***> wrote: @weblancaster <https://github.com/weblancaster> I think I found the issue on why the clientID and accesstokens that I get from the python script aren't working. I tried the build on my laptop, before the update on 12/19, and I was able to play songs just fine. But when I pulled the latest electron from today, that is when I got the API limit error. I am not sure which of the changes that were made that caused it to not work. But I know its the latest update from today that is causing it. I am pretty sure of that — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#894 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABT29Ml-XAS1adixRgyhblT6eBavBV0kks5rJxFXgaJpZM4KXUs8> .

…t when token is expired.

weblancaster · 2016-12-21T01:18:48Z

Merging this work in master since soon or later that will happen and we are not changing anything in master.

weblancaster · 2017-01-11T17:13:30Z

Master has latest fixes which I'm going to release a test version tonight for anyone who is interested. Or just build from master if you don't want/need to wait for me to release.

electron migration start point, bootstrap app using electron prebuilt…

cb92aaa

…, load vendors using npm

weblancaster added the in progress label Oct 14, 2016

weblancaster changed the title ~~electron migration~~ NW.js tp Electron.js migration Oct 14, 2016

This was referenced Oct 14, 2016

Migrate from NW.js to Electron.js #462

Closed

Electron.js migration work #892

Closed

remove not in use codecs/libs from Chrome for NW.js

30177a2

remove all nw.gui references, remove navbar for authenticated and una…

48513be

…uthenticated, wip

weblancaster changed the title ~~NW.js tp Electron.js migration~~ NW.js to Electron.js migration Oct 16, 2016

weblancaster mentioned this pull request Oct 27, 2016

Re-write Soundnode #310

Closed

weblancaster added 6 commits October 28, 2016 11:24

Replace grunt tasks to npm scripts

a45f3b3

- Remove all grunt tasks - Add npm script tasks - Remove jshint since eslint is being used

Add electron native media shortcuts

3a411e6

Notification window new implementation.

9d19829

- Fix window/app action buttons - Improve webpack config

Fix packaging command

72d9c6f

fix toastr request, code refactoring

5fed528

weblancaster added 2 commits November 1, 2016 21:26

add clean to npm scripts

a3616d2

add the menubar commands, links back

54e1807

weblancaster added 2 commits December 19, 2016 01:22

Fix numfmt issue for volume range, use instead window

1a3daea

Fix a couple of http request, fix rate limit notification modal (closes

7fd8d3e

#923), remove not in use code, improve ngDialog styles, fix js error on showMoreDirective.

display notification when API limit reached, closes #923, Log user ou…

ca43179

…t when token is expired.

weblancaster merged commit dfe8184 into master Dec 21, 2016

weblancaster removed the in progress label Dec 21, 2016

weblancaster deleted the electron-migration branch July 19, 2017 23:38

NW.js to Electron.js migration #894

NW.js to Electron.js migration #894

Conversation

weblancaster commented Oct 14, 2016 • edited Loading

ghost commented Oct 14, 2016 via email

weblancaster commented Oct 14, 2016

ghost commented Oct 14, 2016

weblancaster commented Oct 14, 2016

bardiharborow commented Oct 16, 2016 • edited Loading

weblancaster commented Oct 16, 2016

weblancaster commented Oct 30, 2016

jakejarrett commented Oct 30, 2016 • edited Loading

ghost commented Oct 31, 2016 via email

weblancaster commented Oct 31, 2016

weblancaster commented Nov 5, 2016

SW1FT commented Nov 5, 2016 • edited Loading

weblancaster commented Nov 5, 2016

TheNightRider12 commented Dec 16, 2016

TheNightRider12 commented Dec 16, 2016

weblancaster commented Dec 17, 2016

TheNightRider12 commented Dec 17, 2016

ghost commented Dec 17, 2016 • edited by ghost Loading

weblancaster commented Dec 17, 2016

ghost commented Dec 17, 2016

weblancaster commented Dec 17, 2016

TheNightRider12 commented Dec 17, 2016

weblancaster commented Dec 17, 2016

TheNightRider12 commented Dec 17, 2016

weblancaster commented Dec 18, 2016

weblancaster commented Dec 19, 2016

TheNightRider12 commented Dec 19, 2016

TheNightRider12 commented Dec 19, 2016 • edited Loading

TheNightRider12 commented Dec 19, 2016

ghost commented Dec 19, 2016 via email • edited by ghost Loading

TheNightRider12 commented Dec 19, 2016

ghost commented Dec 19, 2016

TheNightRider12 commented Dec 19, 2016

TheNightRider12 commented Dec 19, 2016 • edited Loading

kokarn commented Dec 20, 2016 via email

weblancaster commented Dec 21, 2016

weblancaster commented Jan 11, 2017 • edited Loading

weblancaster commented Oct 14, 2016 •

edited

Loading

bardiharborow commented Oct 16, 2016 •

edited

Loading

jakejarrett commented Oct 30, 2016 •

edited

Loading

SW1FT commented Nov 5, 2016 •

edited

Loading

ghost commented Dec 17, 2016 •

edited by ghost

Loading

TheNightRider12 commented Dec 19, 2016 •

edited

Loading

ghost commented Dec 19, 2016 via email •

edited by ghost

Loading

TheNightRider12 commented Dec 19, 2016 •

edited

Loading

weblancaster commented Jan 11, 2017 •

edited

Loading