Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DIA-3263] The fix of no internet issue: Update to new android SDK version #30

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

Nevazhnovu
Copy link
Collaborator

@Nevazhnovu Nevazhnovu commented Jan 25, 2024

Update for new Android SDK 7.6.0 version

@Nevazhnovu Nevazhnovu changed the title [DIA-3263] Update for new android SDK version [DIA-3263] The fix of no internet issue: Update to new android SDK version Jan 29, 2024
@Nevazhnovu Nevazhnovu changed the base branch from develop to main January 29, 2024 12:38
@Nevazhnovu Nevazhnovu changed the base branch from main to develop January 29, 2024 12:38
@andresilveirah
Copy link
Member

@Nevazhnovu is the iOS SDK also updated to the latest SDK?

@andresilveirah
Copy link
Member

@Nevazhnovu just noticed Android SDK 7.6.1 was released today, can you update your PR to target that version? There should be no differences to the public API, just a bug fix.

throw new ArgumentNullException(nameof(wrappedCcpa), "The CCPA consent wrapper cannot be null.");
{
CmpDebugUtil.LogError("The CCPA consent wrapper cannot be null.");
return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we want to return null instead of throwing an error? I mean, what do we do with the null value after that is being returned from this function? do we do something to handle this case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is a part of unparsing process and I don't mind having the object as null since it is a possible outcome for that object with doesn't break the overall flow. Error handling exists above level in the call tree. The logging is enough for now. Since throwing error triggers entire unparsing process to throw.

Copy link
Collaborator

@bohdan-go-wombat bohdan-go-wombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nevazhnovu
Copy link
Collaborator Author

Nevazhnovu commented Jan 29, 2024

@Nevazhnovu is the iOS SDK also updated to the latest SDK?

@andresilveirah not yet.

just noticed Android SDK 7.6.1 was released today, can you update your PR to target that version? There should be no differences to the public API, just a bug fix.

I'd rather introduce 7.6.1 in a separate branch

@Nevazhnovu Nevazhnovu merged commit b3f7b25 into develop Jan 30, 2024
@andresilveirah andresilveirah deleted the DIA-3263-internet-connection-issue branch February 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants