-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DIA-3263] The fix of no internet issue: Update to new android SDK version #30
Conversation
@Nevazhnovu is the iOS SDK also updated to the latest SDK? |
@Nevazhnovu just noticed Android SDK 7.6.1 was released today, can you update your PR to target that version? There should be no differences to the public API, just a bug fix. |
throw new ArgumentNullException(nameof(wrappedCcpa), "The CCPA consent wrapper cannot be null."); | ||
{ | ||
CmpDebugUtil.LogError("The CCPA consent wrapper cannot be null."); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we want to return null instead of throwing an error? I mean, what do we do with the null value after that is being returned from this function? do we do something to handle this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is a part of unparsing process and I don't mind having the object as null since it is a possible outcome for that object with doesn't break the overall flow. Error handling exists above level in the call tree. The logging is enough for now. Since throwing error triggers entire unparsing process to throw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andresilveirah not yet.
I'd rather introduce 7.6.1 in a separate branch |
Update for new Android SDK 7.6.0 version