Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate control points whose contribution is completely overwritten #93

Merged
merged 11 commits into from
Jan 26, 2025

Conversation

SouthEndMusic
Copy link
Owner

@SouthEndMusic SouthEndMusic commented Jan 24, 2025

Fixes #75

To do:

  • Add docstring for error_informed_local_refinement!
  • Add docstrings for new functions

@SouthEndMusic SouthEndMusic marked this pull request as draft January 24, 2025 09:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 95.09202% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.80%. Comparing base (1cd684b) to head (90a0a24).

Files with missing lines Patch % Lines
src/adjoint.jl 90.27% 7 Missing ⚠️
src/validation.jl 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   92.69%   92.80%   +0.11%     
==========================================
  Files          14       15       +1     
  Lines        1040     1126      +86     
==========================================
+ Hits          964     1045      +81     
- Misses         76       81       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouthEndMusic SouthEndMusic marked this pull request as ready for review January 26, 2025 12:15
@SouthEndMusic SouthEndMusic merged commit 0db6bac into master Jan 26, 2025
7 checks passed
@SouthEndMusic SouthEndMusic deleted the deactivate_overwritten_control_points branch January 26, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local refinement: deactivate control points whose contribution is completely overwritten
2 participants