Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DaService::new an async function #506

Closed
preston-evans98 opened this issue Jul 17, 2023 · 1 comment
Closed

Make DaService::new an async function #506

preston-evans98 opened this issue Jul 17, 2023 · 1 comment
Assignees
@bkolad

Comments

@preston-evans98
Copy link
Member

Is your feature request related to a problem? Please describe.
"The communication client I am using is eager to connect and thus requires an async context. That requires me to create a sync wrapper around the client, that will tries to connect on the first access to it, e.g. get_finalized_it."

Describe the solution you'd like
Make DaService::new an async function
@preston-evans98
Copy link
Member Author

This feature request originated in Discord https://discord.com/channels/1050059327626555462/1069729783367336010/1130159348631478413

cc @bkolad, this looks like it's related to #472

@bkolad bkolad self-assigned this Jul 17, 2023
@bkolad bkolad mentioned this issue Jul 17, 2023
Merged
@bkolad bkolad closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkolad bkolad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkolad @preston-evans98