Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DaService async #508

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Make DaService async #508

merged 5 commits into from
Jul 17, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Jul 17, 2023 •
edited
Loading

Description

This PR introduces the following changes:

  1. makes DaService trait async.
  2. makes DaService::new async
  3. makes DaService::get_finalized_at async
  4. makes DaService::get_block_at async
  5. makes DaService::send_transaction async

#507 will be implemented in another PR.

Linked Issues

Testing

All unit tests are passing

Docs

No effects on docs.

@bkolad bkolad marked this pull request as ready for review July 17, 2023 18:39
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #508 (849d864) into nightly (11c6eb3) will increase coverage by 0.0%.
The diff coverage is 27.5%.

Impacted Files Coverage Δ
rollup-interface/src/node/services/da.rs 0.0% <ø> (ø)
adapters/celestia/src/da_service.rs 62.3% <26.5%> (+<0.1%) ⬆️
full-node/sov-sequencer/src/lib.rs 78.1% <40.0%> (ø)

@bkolad bkolad merged commit 70e563d into nightly Jul 17, 2023
@bkolad bkolad deleted the blaze/async_da_service branch July 17, 2023 20:27
citizen-stig pushed a commit that referenced this pull request Jul 20, 2023
@bkolad @citizen-stig
Make DaService async (#508)
8d84aac
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
@bkolad @preston-evans98
Make DaService async (#508)
397d55d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preston-evans98 preston-evans98 preston-evans98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use async_trait for DaService
2 participants
@bkolad @preston-evans98