Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bech32m address encoding #420

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Switch to bech32m address encoding #420

merged 2 commits into from
Jun 20, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR updates our address encoding from bech32 to bech32m, which has a more robust checksum. See BIP 350 for more detail.

Testing

Tests are updated

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #420 (cc2c1db) into main (c6f6311) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
...m/module-implementations/sov-accounts/src/tests.rs 99.4% <100.0%> (ø)
module-system/sov-modules-api/src/bech32.rs 93.3% <100.0%> (ø)
module-system/sov-modules-api/src/serde_address.rs 90.0% <100.0%> (ø)
module-system/sov-modules-api/src/tests.rs 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

@preston-evans98 preston-evans98 merged commit 758bb4e into main Jun 20, 2023
@preston-evans98 preston-evans98 deleted the preston/bech32m branch June 20, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants