add macros to generate clap commands and args for modules in runtime

[dubbelosix]

Description

We currently let the users use sov-cli by passing in a json file that contains a json representation of the CallMessage

cargo run --bin sov-cli serialize-call src/sov-cli/test_data/minter_private_key.json Bank src/sov-cli/test_data/create_token.json 1

where src/sov-cli/test_data/create_token.json is

{
    "CreateToken": {
      "salt": 11,
      "token_name": "sov-test-token",
      "initial_balance": 1000,
      "minter_address": "sov15vspj48hpttzyvxu8kzq5klhvaczcpyxn6z6k0hwpwtzs4a6wkvqmlyjd6",
      "authorized_minters": ["sov15vspj48hpttzyvxu8kzq5klhvaczcpyxn6z6k0hwpwtzs4a6wkvqmlyjd6"]
    }
}

This PR adds an additional command to the sov-cli called generate-transaction, which allows the arguments to be specified on the command line.

cargo run --bin sov-cli generate-transaction bank create-token 11 sov-test-token 1000 sov15vspj48hpttzyvxu8kzq5klhvaczcpyxn6z6k0hwpwtzs4a6wkvqmlyjd6

The generated cli will have documentation based on doc comments in the CallMessage enum for each module:

% cargo run --features="cli" --bin sov-cli generate-transaction bank
    Finished dev [unoptimized + debuginfo] target(s) in 0.30s
     Running `/Users/dubbelosix/sovereign/target/debug/sov-cli module bank`
Usage: sov-cli generate-transaction bank <COMMAND>

Commands:
  create-token  Creates a new token with the specified name and initial balance
  transfer      Transfers a specified amount of tokens to the specified address
  burn          Burns a specified amount of tokens
  mint          Mints a specified amount of tokens
  freeze        Freeze a token so that the supply is frozen
  help          Print this message or the help of the given subcommand(s)

Options:
  -h, --help  Print help

Updates July 20 (by @preston-evans98)

This PR has been significantly refactored to address a number of limitations. Now, the cli_parser macro no longer requires the Context type to be provided as part of the annotation. Instead, the cli methods are generated generically so that any context can be configured in the resulting binary.

Remaining work:

• Hide clap dependency behind sov_modules_api
• Refactor cli_parser as a derive macro instead of an attribute
• Refactor cli_skip to be an attribute instead of an arg to cli_parser
• Wrap clap::Parser for structs and standard enums behind our CliWalletArg macro

Linked Issues

• Related to Tracking Issue: sov-cli improvements #552

Testing

Tested using try_build

Docs

Doc comments have been added as appropriate.

[bkolad]

Thanks for the work! The module system now makes clap firs class citizen which is a bit unfortunate. Would it be possible to convert the module CallMessages to some intermediate structures (which we can even serialize to a file, something like abi in ethereum) and generate the clap options from this structures? I looks like we could achieve this by using the clap builder pattern. This way we decouple the dependency + we can use the structures to generate clis in other programming languages or even web clients.

I understand this might be bigger chunk of work (and a will require some research) so I am fine with merging the PR, but I would like to discuss the intermediate structures approach on the daily.

[codecov]

Codecov Report

Merging #423 (738b122) into nightly (fd58400) will decrease coverage by 0.3%.
The diff coverage is 77.5%.

Files Changed	Coverage Δ
adapters/celestia/src/celestia.rs	56.6% <0.0%> (-1.7%)	⬇️
...em/module-implementations/sov-accounts/src/call.rs	75.0% <0.0%> (-5.8%)	⬇️
...system/module-implementations/sov-bank/src/call.rs	87.5% <0.0%> (-7.7%)	⬇️
...ystem/module-implementations/sov-bank/src/token.rs	81.9% <0.0%> (-16.7%)	⬇️
...implementations/sov-sequencer-registry/src/call.rs	87.2% <0.0%> (-6.0%)	⬇️
...dule-system/sov-modules-api/src/default_context.rs	84.2% <0.0%> (-4.7%)	⬇️
...le-system/sov-modules-api/src/default_signature.rs	52.2% <0.0%> (-3.4%)	⬇️
module-system/sov-modules-api/src/lib.rs	61.4% <0.0%> (-6.0%)	⬇️
rollup-interface/src/state_machine/mocks.rs	62.0% <0.0%> (-5.5%)	⬇️
module-system/sov-modules-macros/src/cli_parser.rs	84.7% <83.6%> (-13.8%)	⬇️
... and 2 more

... and 1 file with indirect coverage changes

[bkolad]

Thanks a lot, Preston! I had a couple of old comments about introducing thiserror: https://github.com/Sovereign-Labs/sovereign-sdk/pull/423/files#r1238171744. I think you have mentioned there were some problems with doing this way, right? If this is the case, feel free to close them.