Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jupiter and Sov-CLI bugs #437

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Fix Jupiter and Sov-CLI bugs #437

merged 4 commits into from
Jun 28, 2023

Conversation

preston-evans98
Copy link
Member

Description

This PR fixes several bugs related to sequencing and transaction inclusion:

  1. The genesis block on Celestia does not have a prev_hash, which caused a panic when running on local testnets
  2. Jupiter had an erroneous copy_from_slice which copied into an empty vec with enough capacity but 0 length. This triggered an assertion when processing blobs
  3. The makefile command to submit the create-token transaction to Celestia submitted an individual transaction instead of a batch, causing the transaction to be ignored
  4. The sov-cli had a serialization bug, causing all of its batches to be rejected

@codecov
Copy link

codecov bot commented Jun 28, 2023

@citizen-stig
Copy link
Member

I am nitpicking, but for future it might be a good idea to give branches more descriptive names, like hotfix/cli_and_jupiter_bugs

@dubbelosix dubbelosix marked this pull request as ready for review June 28, 2023 11:01
@citizen-stig citizen-stig changed the title WIP: Fix Jupiter and Sov-CLI bugs Fix Jupiter and Sov-CLI bugs Jun 28, 2023
@dubbelosix dubbelosix merged commit e7244f0 into main Jun 28, 2023
@dubbelosix dubbelosix deleted the hotfix branch June 28, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants