-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust cache for cargo #439
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The benchmarks are very impressive and all changes make sense to me. It would be nice to include a timeout (1h?) for our GH jobs, to save compute in case the CI gets stuck (it doesn't look like it happens at all by glancing at our Actions history but it's a good fail-safe to have, especially since we're doing proptests).
Agree, done! |
Short summary
assert!(matches!())
toassert_eq!()
sccache
instead of hard coded.Description
Currently we use sccache for caching compilation. and it helps, especially with rocksdb, as it can cache not only rust compilation artifacts, but also C/C++.
But it looks like cargo download dependencies everytime and scacche does not handle it that well.
So idea is to put sccache on top of standard rust caching mechanism.
target
)Macro tests
Current macro tests use native flag for testing compilation, which brings compilation of rocksdb second time inside macro test.
I've changed the tests to operate on ZK conteext and ZK storage, as it require less dependencies.
Future improvements
Things that can be done to make CI even smoother:
check
step to be the first and rest depend on it, so it doesn't waste runner's time if it failsSCCACHE_CACHE_SIZE
to get best results