Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Celestia RPC timeout configurable #482

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Make Celestia RPC timeout configurable #482

merged 8 commits into from
Jul 10, 2023

Conversation

preston-evans98
Copy link
Member

Description

Make the Celestia-node RPC timeout configurable

Linked Issues

Testing

Unit testing this change is difficult because the jsonrpsee::HttpClient doesn't expose a getter for its current timeout value - so, this PR leaves the change untested.

Docs

The example rollup_config.toml and its documentation have been updated.

@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #482 (af933dc) into main (e542d7e) will decrease coverage by 1.0%.
The diff coverage is 50.0%.

❗ Current head af933dc differs from pull request most recent head a192345. Consider uploading reports for the commit a192345 to get more accurate results

Impacted Files Coverage Δ
adapters/celestia/src/da_service.rs 14.6% <50.0%> (-47.1%) ⬇️

... and 5 files with indirect coverage changes

@preston-evans98 preston-evans98 merged commit a691a28 into main Jul 10, 2023
@preston-evans98 preston-evans98 deleted the preston/celestia-timeout branch July 10, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen-stig citizen-stig citizen-stig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to set request_timeout for CelestiaAdapter
2 participants
@preston-evans98 @citizen-stig