Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: basic implementation of eth_sendRawTransaction #487

Merged
merged 9 commits into from
Jul 11, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Jul 11, 2023

Description

This PR introduces the following changes:

  1. sov-etehreum crate in full-node. This crate provides eth_sendRawTransaction rpc endpoint. This endpoint wraps evm transaction in rollup transaction and sends it to celestia (the endpoint will be generic over DA in the future).
    Currently, the implementation is very basic. The logic panics if unexpected data is encountered, and some of the values in the request are hardcoded to defaults. Despite these limitations, it is sufficient for a simple unit test to function and will be improved in future pull requests.

  2. Adds a couple of ethereum rpc endpoints in sov-evm/src/query.rs. Once again, the implementation is minimal and will be expanded upon in the next pull requests.

Linked Issues

Testing

Tested the new endpoint manually.

@bkolad bkolad requested a review from citizen-stig July 11, 2023 09:00
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #487 (67ab4f9) into main (e542d7e) will decrease coverage by 1.4%.
The diff coverage is 4.4%.

Impacted Files Coverage Δ
...stem/module-implementations/sov-evm/src/evm/mod.rs 100.0% <ø> (ø)
...system/module-implementations/sov-evm/src/query.rs 0.0% <0.0%> (ø)
full-node/sov-ethereum/src/lib.rs 1.0% <1.0%> (ø)
...e-system/module-implementations/sov-evm/src/lib.rs 90.3% <100.0%> (+2.3%) ⬆️

... and 15 files with indirect coverage changes

@bkolad bkolad changed the title EVM: basic implementation of eth_sendRawTransaction #485 EVM: basic implementation of eth_sendRawTransaction Jul 11, 2023
@bkolad bkolad requested a review from dubbelosix July 11, 2023 09:49
@bkolad bkolad merged commit 836c56e into main Jul 11, 2023
@bkolad bkolad deleted the blaze/evm_rpc_methods branch July 11, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants