Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-rocksdb to 0.21.0 #499

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Bump rust-rocksdb to 0.21.0 #499

merged 1 commit into from
Jul 18, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Jul 17, 2023

Description

rust-rocksdb 0.21.0 ships several build fixes compared to 0.19.0 and uses RocksDB 8.0.0, with more bug fixes and performance improvements.

Linked Issues

None

Testing

No testing, we shouldn't see any behavior difference.

@neysofu neysofu requested a review from citizen-stig July 17, 2023 10:28
@neysofu neysofu force-pushed the filippo/rocksdb-021 branch from 0e12f20 to 617cf05 Compare July 17, 2023 12:03
@citizen-stig
Copy link
Member

I wonder to see this PR has impact on benchmark we have.

@neysofu
Copy link
Member Author

neysofu commented Jul 17, 2023

I don't expect to see much of a difference, but who knows. I read that they changed how CPU feature detection is done at compile-time, that might have some impact. I'll look into it 🙂

@neysofu neysofu merged commit c38d821 into nightly Jul 18, 2023
@neysofu neysofu deleted the filippo/rocksdb-021 branch July 18, 2023 09:08
citizen-stig pushed a commit that referenced this pull request Jul 20, 2023
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants