-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make DaService::get_extraction_proof
async
#511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolad
commented
Jul 18, 2023
bkolad
changed the title
make
make Jul 18, 2023
DaService ::get_extraction_proof
asyncDaService::get_extraction_proof
async
citizen-stig
approved these changes
Jul 18, 2023
Codecov Report
|
neysofu
approved these changes
Jul 18, 2023
preston-evans98
approved these changes
Jul 18, 2023
citizen-stig
pushed a commit
that referenced
this pull request
Jul 20, 2023
preston-evans98
pushed a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
DaService::get_extraction_proof
function asyncSend and Sync
bounds toBlobTransactionTrait & SlotData
( required by point 1).CelestiaHeader:: cached_prev_has
so it isSend & Sync
Linked Issues
DaService::get_extraction_proof
an async function #507Testing
All tests are passing.
Docs
No impact on docs.