Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DaService::get_extraction_proof async #511

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Jul 18, 2023

Description

This PR introduces the following changes:

  1. Makes DaService::get_extraction_proof function async
  2. Adds Send and Sync bounds to BlobTransactionTrait & SlotData( required by point 1).
  3. Introduces mutex for CelestiaHeader:: cached_prev_has so it is Send & Sync

Linked Issues

Testing

All tests are passing.

Docs

No impact on docs.

@bkolad bkolad marked this pull request as ready for review July 18, 2023 09:22
@bkolad bkolad changed the title make DaService ::get_extraction_proof async make DaService::get_extraction_proof async Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #511 (890912d) into nightly (70e563d) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Impacted Files Coverage Δ
adapters/celestia/src/celestia.rs 60.6% <0.0%> (-0.9%) ⬇️
adapters/celestia/src/da_service.rs 62.3% <0.0%> (ø)
full-node/sov-sequencer/src/lib.rs 78.1% <0.0%> (ø)
rollup-interface/src/node/services/da.rs 0.0% <0.0%> (ø)
rollup-interface/src/state_machine/da.rs 75.8% <ø> (ø)

... and 3 files with indirect coverage changes

@bkolad bkolad merged commit f64576c into nightly Jul 18, 2023
@bkolad bkolad deleted the blaze/get_extraction_proof_async branch July 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DaService::get_extraction_proof an async function
4 participants