Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependecies #523

Merged
merged 9 commits into from
Jul 19, 2023
Merged

Conversation

citizen-stig
Copy link
Member

Description

Removing dependencies that crates are not actually using. Cleaner Cargo.toml files

Testing

Automated tests have passed

Docs

Not applicable.

@citizen-stig citizen-stig self-assigned this Jul 19, 2023
@citizen-stig citizen-stig force-pushed the chores/remove_unused_dependecies branch from 377c5c0 to 987e345 Compare July 19, 2023 10:38
@citizen-stig citizen-stig marked this pull request as ready for review July 19, 2023 10:39
@citizen-stig citizen-stig marked this pull request as draft July 19, 2023 10:40
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #523 (709017d) into nightly (3b77d2c) will increase coverage by 0.0%.
The diff coverage is 91.8%.

Impacted Files Coverage Δ
adapters/celestia/src/share_commit.rs 0.0% <ø> (ø)
...-system/module-implementations/sov-bank/src/lib.rs 95.0% <0.0%> (-2.5%) ⬇️
module-system/sov-modules-api/src/lib.rs 53.8% <0.0%> (-1.1%) ⬇️
...nterface/src/state_machine/crypto/simple_hasher.rs 0.0% <ø> (ø)
rollup-interface/src/state_machine/da.rs 75.8% <ø> (ø)
...system/module-implementations/sov-bank/src/call.rs 95.2% <50.0%> (-0.7%) ⬇️
...ystem/module-implementations/sov-bank/src/token.rs 98.5% <50.0%> (-0.8%) ⬇️
...m/module-implementations/sov-accounts/src/tests.rs 99.4% <100.0%> (ø)
module-system/module-schemas/src/lib.rs 100.0% <100.0%> (ø)
module-system/sov-modules-macros/src/common.rs 79.1% <100.0%> (+0.8%) ⬆️
... and 6 more

@citizen-stig citizen-stig marked this pull request as ready for review July 19, 2023 10:54
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in a a crate description; feel free to merge after fixing that!

@citizen-stig citizen-stig merged commit ef12744 into nightly Jul 19, 2023
@citizen-stig citizen-stig deleted the chores/remove_unused_dependecies branch July 19, 2023 13:09
citizen-stig added a commit that referenced this pull request Jul 20, 2023
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants