sov-modules: Ensure that the internal structure of modules implementation is private. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkolad
changed the title
citizen-stig
approved these changes
Jul 21, 2023
preston-evans98
pushed a commit
that referenced
this pull request
Sep 14, 2023
…tion is private. (#541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the internals of Sov modules private so the implementation details don't leak outside of the module.
Linked Issues
Testing
All tests pass
Docs
In the documentation, we recommend following the convention of dividing a sov module into
call.rs, query.rs, and hooks.rs. However, we don't explicitly state that these Rust modules must be public. Therefore, there are no changes required in the documentation regarding this matter.