Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all Runtime macros to handle multiple generics #575

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Allow all Runtime macros to handle multiple generics #575

merged 7 commits into from
Jul 27, 2023

Conversation

preston-evans98
Copy link
Member

Description

Previously, many of the macros on Runtime could not handle more than one generic argument. This PR allows all of our macros to handle multiple generics appropriately.

Linked Issues

Testing

Unit tests have been updated. I also added a dummy generic to Bank and derived/ran the code for demo-rollup with multiple generics.

bkolad
bkolad approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@preston-evans98 preston-evans98 merged commit d4b39e3 into nightly Jul 27, 2023
@preston-evans98 preston-evans98 deleted the preston/generic_macros branch July 27, 2023 20:55
preston-evans98 added a commit that referenced this pull request Sep 14, 2023
@preston-evans98
Allow all Runtime macros to handle multiple generics (#575)
9821a17 
* use ThisError for CelestiaAddress::FromStr

* Update macros to handle multiple generics

* Add missing generic to demo-rollup rpc

* Revert unneeded changes to modules-api

* Test with multiple generics

* Fix clippy warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkolad bkolad bkolad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derive_rpc fails when module has multiple generics
2 participants
@preston-evans98 @bkolad