Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State: Add serde support for StateMap, StateValue.. etc structures #805

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Sep 7, 2023

Description

This PR adds serde support for StateXX structures so they can be serialized recursively with different codecs than borsh

Testing

CI passes.

Docs

No doc changes.

@bkolad bkolad marked this pull request as ready for review September 7, 2023 09:18
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #805 (de4625b) into nightly (1adbfc9) will decrease coverage by 0.3%.
The diff coverage is 20.3%.

Files Changed Coverage Δ
...e-system/sov-state/src/containers/accessory_map.rs 53.8% <0.0%> (-4.5%) ⬇️
...system/sov-state/src/containers/accessory_value.rs 40.8% <0.0%> (-12.7%) ⬇️
module-system/sov-state/src/containers/value.rs 69.7% <0.0%> (-11.4%) ⬇️
module-system/sov-state/src/containers/vec.rs 90.8% <12.5%> (-2.9%) ⬇️
...e-system/sov-state/src/containers/accessory_vec.rs 86.6% <22.2%> (-2.6%) ⬇️
module-system/sov-state/src/containers/map.rs 93.4% <42.8%> (-5.2%) ⬇️
module-system/sov-state/src/lib.rs 76.3% <42.8%> (-8.1%) ⬇️
module-system/sov-state/src/utils.rs 77.4% <42.8%> (-10.6%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@preston-evans98 preston-evans98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Go ahead and merge and then I'll handle merging with #804

@bkolad bkolad added this pull request to the merge queue Sep 7, 2023
Merged via the queue into nightly with commit 2765334 Sep 7, 2023
@bkolad bkolad deleted the blaze/serde_prefix branch September 7, 2023 14:07
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants