Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to unify evm Address and U256 types, serializing with serde #825

Merged
merged 7 commits into from
Sep 8, 2023

Conversation

LukaszRozmej
Copy link
Contributor

Description

Refactor to simplify conversions
Serialize with serde

@LukaszRozmej LukaszRozmej requested a review from bkolad September 8, 2023 10:22
@LukaszRozmej LukaszRozmej marked this pull request as ready for review September 8, 2023 10:22
examples/demo-stf/Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #825 (bbd22ae) into nightly (44db227) will increase coverage by 0.1%.
The diff coverage is 98.3%.

Files Changed Coverage Δ
...stem/module-implementations/sov-evm/src/genesis.rs 98.7% <75.0%> (ø)
full-node/sov-ethereum/src/lib.rs 92.7% <100.0%> (-0.2%) ⬇️
...-system/module-implementations/sov-evm/src/call.rs 95.0% <100.0%> (ø)
...ule-implementations/sov-evm/src/evm/conversions.rs 67.9% <100.0%> (+0.7%) ⬆️
...ystem/module-implementations/sov-evm/src/evm/db.rs 80.0% <100.0%> (ø)
...odule-implementations/sov-evm/src/evm/db_commit.rs 95.8% <100.0%> (-0.2%) ⬇️
.../module-implementations/sov-evm/src/evm/db_init.rs 100.0% <100.0%> (ø)
...stem/module-implementations/sov-evm/src/evm/mod.rs 100.0% <100.0%> (ø)
...em/module-implementations/sov-evm/src/evm/tests.rs 97.8% <100.0%> (ø)
...ule-implementations/sov-evm/src/evm/transaction.rs 81.8% <100.0%> (ø)
... and 2 more

... and 5 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@LukaszRozmej LukaszRozmej added this pull request to the merge queue Sep 8, 2023
Merged via the queue into nightly with commit 83ba024 Sep 8, 2023
@LukaszRozmej LukaszRozmej deleted the evm/unify_types branch September 8, 2023 13:04
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
…de (#825)

* Refactoring to unify evm Address and U256 types, serializing with serde

* simplify

* remove TODO

* even less conversions

* few more

* fix for experimental dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants