Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Implement Gas Oracle #975

Merged
merged 35 commits into from
Oct 18, 2023
Merged

Conversation

orkunkilic
Copy link
Contributor

@orkunkilic orkunkilic commented Oct 3, 2023

Description

This PR adopts gas price estimation logic from Reth by copying their gas oracle implementation into a new sov-ethereum-gas-price module. Module is connected to the demo rollup and tests are added.

This also adds getBlockByHash endpoint, which is required for gas oracle cache.

Linked Issues

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@orkunkilic orkunkilic marked this pull request as draft October 3, 2023 08:15
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #975 (ca1a973) into nightly (d874bd5) will decrease coverage by 4.1%.
The diff coverage is 0.0%.

❗ Current head ca1a973 differs from pull request most recent head dab4b02. Consider uploading reports for the commit dab4b02 to get more accurate results

Files Coverage Δ
...e-system/module-implementations/sov-evm/src/lib.rs 95.0% <ø> (ø)
module-system/sov-modules-api/src/gas.rs 77.5% <ø> (ø)
module-system/sov-state/src/lib.rs 84.2% <ø> (ø)
module-system/sov-state/src/storage.rs 94.3% <ø> (ø)
...system/module-implementations/sov-evm/src/query.rs 0.0% <0.0%> (ø)

... and 48 files with indirect coverage changes

@orkunkilic orkunkilic marked this pull request as ready for review October 10, 2023 10:52
@orkunkilic orkunkilic marked this pull request as draft October 10, 2023 11:35
@orkunkilic orkunkilic marked this pull request as ready for review October 17, 2023 13:46
@orkunkilic orkunkilic marked this pull request as draft October 17, 2023 14:23
@orkunkilic orkunkilic marked this pull request as ready for review October 18, 2023 09:54
@bkolad bkolad enabled auto-merge October 18, 2023 12:43
@bkolad bkolad added this pull request to the merge queue Oct 18, 2023
Merged via the queue into Sovereign-Labs:nightly with commit e75f8cf Oct 18, 2023
12 checks passed
@bkolad bkolad deleted the orkun/gas-price branch October 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM: Implement eth_gasPrice endpoint.
2 participants