WIP: Add low-level RF send and receive functions #306

PatrickKa · 2024-06-27T13:11:59Z

Fixes #187
Fixes #154

codecov-commenter · 2024-06-27T13:37:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (d35c62e) to head (15fa6fc).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files          58       58           
  Lines        2359     2359           
  Branches      106      106           
=======================================
  Hits         2080     2080           
  Misses        279      279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We must not pull the CS pin high (= deselect the chip) between reading the CTS value and reading a potential command reply.

Also, enable additional interrupts in rf::ReceiveTestData()

…gger)

The unit test only checks the part number. The manual test can send or receive test data.

There is a persistent variable for that.

Also, remove or mark unused private functions.

PatrickKa force-pushed the rf-send-187 branch from d923b37 to 0cc6cbe Compare June 27, 2024 13:34

danielschloms and others added 28 commits March 1, 2025 16:32

Add functions to clear FIFOs and interrupts

d299ff2

Add MFT code for rf::Send() and make it compile

c639c43

Fix typos and add TODO and FIXME comments

a136e53

Use void pointers for low-level RF functions

cc74b45

Use "new" SPI interface to make Rf.cpp compile again

3cecc1b

Add rf::RecieveTestData() from mft branch and make it compile

9925617

Extend Rf.test.cpp by sending a message

cebe5be

Format code

82e26d2

DEBUG_PRINT() actual baud rate of RF SPI

6956010

Use WaitForCts() in WriteToFifo()

578a0f7

Add DEBUG_PRINT()s in rf::Send() and rf::WriteToFifo()

da7fb19

Add rf::ReadDeviceState()

f22ea22

Add rf::ReadFunctionInfo()

b4cb35e

Add rf::ReadPartInfo()

456095e

Add DEBUG_PRINT()s to both SendCommand functions

e591611

Reorder rf::Read...() in Rf.test.cpp

b671695

Fix WaitForCts() and receiving answers

a265147

We must not pull the CS pin high (= deselect the chip) between reading the CTS value and reading a potential command reply.

Fix printing part info in Rf.test.cpp

af61912

Send test message in Rf.test.cpp again

0c97fd0

Send test message multiple times

b9f7d1a

Set LED 1 pin when sending in Rf.test.cpp

fd8da28

Update message that's sent in Rf.test.cpp

b1e2640

Remove all DEBUG_PRINT()s from rf::Send() and rf::WriteToFifo()

ee7ebe0

Fix typo in rf::ReceiveTestData()

d4c9bab

Update RF module configuration

71d847b

Receive test data in Rf.test.cpp

edf9f0b

Only read part number in Rf.test.cpp before TX and RX

452c8bb

Remove unnecessary StartTx() calls in rf::Send()

b62f8c2

PatrickKa and others added 11 commits March 1, 2025 16:39

Add rf::ReadModemStatus()

edc1f2e

Rework rf::ClearInterrupts() to rf::ReadAndClearInterruptStatus()

51d6993

Also, enable additional interrupts in rf::ReceiveTestData()

Add rf::ApplyPatch()

fa8b7ba

feat(Rf): use parameters generated by WDS tool

b8ddcc3

STASH: Add radio_config_Si4463.h and si446x_patch.h

f4a1a30

fix(rf): change some modem config values

2d24474

fix(clang-tidy): clang 19 does not know this setting anymore

b5252da

fix: make it compile again

412bed8

feat: get TX test to *almost* work (TX FiFo almost empty does not tri…

212a188

…gger)

feat: TX is now working

233ae59

feat(rf): RX is working

c2d7e60

PatrickKa force-pushed the rf-send-187 branch from ba744ee to c2d7e60 Compare March 6, 2025 14:56

PatrickKa added 2 commits March 6, 2025 16:33

Remove unused functions and format code

a860e2e

Replace magic numbers with named constants

b8a9818

PatrickKa force-pushed the rf-send-187 branch from c609f5f to ab9a1b6 Compare March 6, 2025 16:38

PatrickKa added 2 commits March 6, 2025 16:38

Refactor Rf.test.cpp

1842807

Use Serialize(nBytes) instead of doing it by hand

d53c75f

PatrickKa force-pushed the rf-send-187 branch from ab9a1b6 to d53c75f Compare March 6, 2025 16:38

PatrickKa and others added 10 commits March 6, 2025 16:59

Split RF test into unit test and manual test

ead5c54

The unit test only checks the part number. The manual test can send or receive test data.

Improve manual RF test

b0d7544

Split manual RF test into one for sending and one for receiving

98cbd8c

Fix includes and use our type-safe time functions

7b23352

Remove rfIsWorking

99458d5

There is a persistent variable for that.

Refactor rf::Send() and rf::Receive()

1e955a8

Give private variables, functions, and types internal linkage

15fa6fc

Also, remove or mark unused private functions.

Reorder private RF functions

67821ea

Use Experimental Outcome for error handling in RF code

d2b1630

Fix error handling in RF receive test

52d78b2

PatrickKa force-pushed the rf-send-187 branch from abc9b2b to 52d78b2 Compare March 8, 2025 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Add low-level RF send and receive functions #306

WIP: Add low-level RF send and receive functions #306

PatrickKa commented Jun 27, 2024

codecov-commenter commented Jun 27, 2024 •

edited

Loading

WIP: Add low-level RF send and receive functions #306

Are you sure you want to change the base?

WIP: Add low-level RF send and receive functions #306

Conversation

PatrickKa commented Jun 27, 2024

codecov-commenter commented Jun 27, 2024 • edited Loading

Codecov Report

codecov-commenter commented Jun 27, 2024 •

edited

Loading