Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake syntax highlighting bug #326

Closed
Curculigo opened this issue Sep 2, 2024 · 1 comment
Closed

CMake syntax highlighting bug #326

Curculigo opened this issue Sep 2, 2024 · 1 comment
Assignees
@SpartanJ
Labels
bug Something isn't working ready for release syntax highlight

Comments

@Curculigo
Copy link

This particular file troubled ecode's syntax highlighter engine:

https://github.com/cnjinhao/nana/blob/a9398c1a4a855218b6b02bcf86969b38f6a892b7/build/cmake/compilers.cmake

Github highlights it correctly, ecode will consider this line as a comment:

if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang") #  AND NOT MINGW??

https://github.com/cnjinhao/nana/blob/a9398c1a4a855218b6b02bcf86969b38f6a892b7/build/cmake/compilers.cmake#L15
@SpartanJ SpartanJ self-assigned this Sep 2, 2024
@SpartanJ SpartanJ added bug Something isn't working syntax highlight labels Sep 2, 2024
SpartanJ added a commit to SpartanJ/eepp that referenced this issue Sep 2, 2024
@SpartanJ
Highlight fix for comments in a few languages (SpartanJ/ecode#326).
2440621 
Don't open welcome tab when documents are already opened in a new session (SpartanJ/ecode#325).
@SpartanJ
Copy link
Owner

SpartanJ commented Sep 2, 2024

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpartanJ SpartanJ

Labels
bug Something isn't working ready for release syntax highlight
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpartanJ @Curculigo