Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4.4] Freezing on Windows after switching projects multiple times #45

Closed
andy0x10 opened this issue Feb 10, 2023 · 16 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@andy0x10
Copy link

Today I have managed to get ecode to freeze (lock-up) several times.

This has never happened before.

The only thing I've been doing differently today is switching between folders (projects) several times.

image

I'm not sure what other information I can provide to help find the bug.

Thanks,

@SpartanJ SpartanJ self-assigned this Feb 10, 2023
@SpartanJ SpartanJ added the bug Something isn't working label Feb 10, 2023
@SpartanJ
Copy link
Owner

That's probably because it's still scanning all folders while you open new folders. I think i forgot to stop the scanning when changing folders (the scan is really fast in SSDs and never thought about it).

@andy0x10
Copy link
Author

Yep, that might be it.

I'm running on a fast NVME SSD though... but still it sounds likely as there are a ton of files in some of these project subfolders.

Thanks,

@SpartanJ
Copy link
Owner

Can you send me your logs? The file tree size and the time it took to analyze it is logged there. It might give me an idea.

@andy0x10
Copy link
Author

Sure, where do I find the logs?

@SpartanJ
Copy link
Owner

SpartanJ commented Feb 10, 2023

Linux: uses XDG_CONFIG_HOME, usually translates to ~/.config/ecode/ecode.log
macOS: uses Application Support folder in HOME, usually translates to ~/Library/Application Support/ecode/ecode.log
Windows: uses APPDATA, usually translates to C:\Users\{username}\AppData\Roaming\ecode\ecode.log

@andy0x10
Copy link
Author

ecode.log

@andy0x10
Copy link
Author

Just happened again while I was typing..

image

Hmmm...

@SpartanJ
Copy link
Owner

I think it's the LSP. LSP is broken in 0.4.4 on Windows, please use this build:
ecode-windows-0.4.4-x86_64.zip. It should fix the issue...

@SpartanJ
Copy link
Owner

Let me know if you get diagnostics and code completion in the new build. Something weird is going on with Omnisharp. Also if you can run ecode with debug log will be really helpful, debug logs are enabled by running ecode.exe -ldebug.

@andy0x10
Copy link
Author

ecode.log

Here's a new log...seems to be an exception - not sure if that's the cause of the freezing or something else.

I can remove Omnisharp to see if it still has this issue.. It's easy to reproduce for me with this project.

Thanks,

@andy0x10
Copy link
Author

Yes, without Omnisharp the freeze doesn't seem to happen. Aslo I noticed a bunch of zombie Omnisharp.exe processes that must have been related to each time I force closed ecode.

I hope this helps but not sure what you can do to fix it :-)

Let me know if you need any more information.

Cheers,

@SpartanJ
Copy link
Owner

It seems I don't gracefully handle a stuck LSP, my theory is that all the pool threads are being frozen by the LSP. I'll check out how to reproduce it. Your particular case should be easy to fix, the OmniSharp installation is lacking MSBuild that it's required to properly function. You need to install MSBuild.

SpartanJ added a commit to SpartanJ/eepp that referenced this issue Feb 13, 2023
Fixes for SpartanJ/ecode#45.
Minor performance optimizations.
Minor bug fixes.
@SpartanJ
Copy link
Owner

SpartanJ commented Feb 14, 2023

I won't close the issue until I'm 100% sure a freeze can happen. I've been trying to reproduce the bug but I wasn't able, but, I was able to reproduce the zombie processes, and it's fixed for sure. I tested with your same OmniSharp setup (I mean, even without MSBuild installed), and worked fine (of course OmniSharp won't work), OmniSharp with MSBuild installed works nicely as far as I could test, but I'm not a C# user so I'm not sure how good it is.
A new release with a ton of fixes will be released very soon (maybe in a few hours I can build all the platforms).

@andy0x10
Copy link
Author

Thanks I will test and let you know.

@andy0x10
Copy link
Author

I haven't had the freeze since 0.4.5 so I guess it must be solved 👍

@SpartanJ
Copy link
Owner

Awesome! Thank you for testing it. I'll close the issue, and if you see something wrong just let me know and I'll re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants